Skip to content

fix(jasmine,allure): preserve nested describe structure (#13953)#15013

Merged
christian-bromann merged 4 commits intowebdriverio:mainfrom
mccmrunal:fix/issue-13953-nested-suites
Jan 17, 2026
Merged

fix(jasmine,allure): preserve nested describe structure (#13953)#15013
christian-bromann merged 4 commits intowebdriverio:mainfrom
mccmrunal:fix/issue-13953-nested-suites

Conversation

@mccmrunal
Copy link
Contributor

Proposed changes

  1. Jasmine Reporter - The [suiteStarted]
    ethod used this._parent.reverse() which mutates the array in-place, corrupting the parent suite stack for subsequent nested suites.

  2. Allure Reporter - The [_startTest]
    method opened a scope but [_endTest] never closed it, causing test scopes to leak into suite containers and creating incorrect nesting.
    //: # (Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.)

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

…13953)

- Fix array mutation in Jasmine reporter
- Fix scope leak in Allure reporter
- Add regression tests
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 13, 2026

Open in StackBlitz

create-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/create-wdio@15013

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@15013

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@15013

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@15013

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@15013

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@15013

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@15013

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@15013

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@15013

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@15013

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@15013

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@15013

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@15013

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@15013

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@15013

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@15013

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@15013

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@15013

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@15013

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@15013

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@15013

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@15013

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@15013

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@15013

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@15013

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@15013

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@15013

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@15013

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@15013

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@15013

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@15013

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@15013

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@15013

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@15013

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@15013

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@15013

@wdio/xvfb

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/xvfb@15013

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@15013

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@15013

commit: b851c73

PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to
allow beforeSession hook to override it. The tests were not updated
and still expected the config values (2, 3).

This updates the test assertions to expect -1, matching the new
initialization behavior.
@mccmrunal mccmrunal closed this Jan 13, 2026
@mccmrunal mccmrunal reopened this Jan 13, 2026
@mccmrunal mccmrunal force-pushed the fix/issue-13953-nested-suites branch from e651574 to 89d4550 Compare January 15, 2026 10:50
@mccmrunal mccmrunal closed this Jan 15, 2026
@mccmrunal mccmrunal reopened this Jan 15, 2026
@mccmrunal mccmrunal force-pushed the fix/issue-13953-nested-suites branch from 89d4550 to b851c73 Compare January 15, 2026 15:10
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Jan 17, 2026
@christian-bromann christian-bromann merged commit 0e4a278 into webdriverio:main Jan 17, 2026
9 checks passed
@wdio-bot
Copy link
Contributor

Hey mccmrunal 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Expensable $15 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants