Skip to content

test(cli): fix launcher tests for specFileRetries -1 initialization#14998

Merged
christian-bromann merged 1 commit intowebdriverio:mainfrom
mccmrunal:fix/launcher-tests-specfileretries
Jan 13, 2026
Merged

test(cli): fix launcher tests for specFileRetries -1 initialization#14998
christian-bromann merged 1 commit intowebdriverio:mainfrom
mccmrunal:fix/launcher-tests-specfileretries

Conversation

@mccmrunal
Copy link
Contributor

@mccmrunal mccmrunal commented Jan 9, 2026

Proposed changes

PR #14859 changed specFileRetries initialization to -1 (unknown) to allow the beforeSession hook to override it. However, the launcher tests were not updated and still expected the config values (2, 3), causing test failures.

This updates the test assertions to expect -1, matching the new initialization behavior.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

PR webdriverio#14859 changed specFileRetries initialization to -1 (unknown) to
allow beforeSession hook to override it. The tests were not updated
and still expected the config values (2, 3).

This updates the test assertions to expect -1, matching the new
initialization behavior.
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 9, 2026

Open in StackBlitz

create-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/create-wdio@14998

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14998

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14998

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14998

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14998

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14998

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14998

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14998

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14998

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14998

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14998

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14998

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14998

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14998

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14998

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14998

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14998

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14998

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14998

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14998

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14998

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14998

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14998

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14998

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14998

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14998

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14998

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14998

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14998

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14998

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14998

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14998

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14998

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14998

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14998

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14998

@wdio/xvfb

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/xvfb@14998

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14998

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14998

commit: e1f6683

@christian-bromann christian-bromann merged commit 88562e2 into webdriverio:main Jan 13, 2026
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants