Merged
Conversation
…LRound in rounds > 0 This condition is really hard to get. Initially, lockedRound and validRound are set to -1 as we start with round 0. Refs #2702
Merge pull request #2750 from tendermint/release/v0.26.0
…dation if some process locks a block in round 0, then 0 is valid proposal.PO…
* mempool: ErrPreCheck and more log info * change Pre/PostCheckFunc to return errors also, continue execution when checking txs in mempool_test if err=PreCheckErr
#2756) * Fix crypto/merkle ProofOperators.Verify to check bounds on keypath parts. * Update PENDING
* p2p: peer-id -> peer_id * update changelog
* dedup with spec/abci/client-server * fixup abci/readme * link to getting started in abci/README * https * spec/abci: some deduplication * docs: remove extraneous comment
It's OK if the head will grow a little bit bigger, but we'll avoid panic. Refs #2703
* p2p: re-check after sleeps * use NodeInfo as an interface * Revert "use NodeInfo as an interface" This reverts commit 5f7d055. * Revert "p2p: re-check after sleeps" This reverts commit 7f41070. * preserve dial to itself * ignore ensured connections while re-connecting * re-check after sleep * keep protocol definition on net addresses * decrease log level * Revert "preserve dial to itself" This reverts commit 0c6e0fc. * correct func comment according to modification Co-Authored-By: mgurevin <mehmet@gurevin.net>
* fix amino overhead computation for Tx: - also count the fieldnum / typ3 - add method to compute overhead per Tx - slightly clarify comment on MaxAminoOverheadForBlock - add tests * fix TestReapMaxBytesMaxGas according to amino overhead * fix TestMempoolFilters according to amino overhead * address review comments: - add a note about fieldNum = 1 - add forgotten godoc comment * fix and use sm.TxPreCheck * fix test * remove print statement
* changelog and version * fix changelog
Codecov Report
@@ Coverage Diff @@
## master #2807 +/- ##
==========================================
+ Coverage 62.24% 62.29% +0.04%
==========================================
Files 212 212
Lines 17184 17219 +35
==========================================
+ Hits 10697 10727 +30
- Misses 5588 5591 +3
- Partials 899 901 +2
|
melekes
approved these changes
Nov 12, 2018
Contributor
ebuchman
added a commit
that referenced
this pull request
Nov 12, 2018
Merge pull request #2807 from tendermint/release/v0.26.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

https://github.com/tendermint/tendermint/blob/533b3cfb739aaa432faa25b58a4729305267329e/CHANGELOG.md#v0261