Skip to content

Release/v0.26.1#2807

Merged
ebuchman merged 20 commits intomasterfrom
release/v0.26.1
Nov 12, 2018
Merged

Release/v0.26.1#2807
ebuchman merged 20 commits intomasterfrom
release/v0.26.1

Conversation

@ebuchman
Copy link
Contributor

melekes and others added 20 commits October 25, 2018 16:40
…LRound in rounds > 0

This condition is really hard to get. Initially, lockedRound and
validRound are set to -1 as we start with round 0.

Refs #2702
Merge pull request #2750 from tendermint/release/v0.26.0
…dation

if some process locks a block in round 0, then 0 is valid proposal.PO…
* mempool: ErrPreCheck and more log info

* change Pre/PostCheckFunc to return errors

also, continue execution when checking txs in mempool_test if
err=PreCheckErr
…ermission errors (#2758)

* only invoke InitWAL/CloseWAL if WalPath is not empty

Closes #2717

* panic if WAL is not initialized when calling CloseWAL

* add a changelog entry
#2756)

* Fix crypto/merkle ProofOperators.Verify to check bounds on keypath parts.

* Update PENDING
This is a follow-up from #2724

Closes #2761
* p2p: peer-id -> peer_id

* update changelog
* dedup with spec/abci/client-server

* fixup abci/readme

* link to getting started in abci/README

* https

* spec/abci: some deduplication

* docs: remove extraneous comment
It's OK if the head will grow a little bit bigger, but we'll avoid
panic.

Refs #2703
…mediately after sending pex addrs in seed mode (#2797)

* Require addressbook to only store addresses with valid ID

* Do not shut down peer immediately after sending pex addrs in SeedMode

* p2p: fix #2773

* seed mode: use go-routine to sleep before stopping peer
)

- actually call `ps.SetHasVote` instead to avoid carrying around
`votes.Height()`, `votes.Round()`, `types.SignedMsgType(votes.Type())`
* p2p: re-check after sleeps

* use NodeInfo as an interface

* Revert "use NodeInfo as an interface"

This reverts commit 5f7d055.

* Revert "p2p: re-check after sleeps"

This reverts commit 7f41070.

* preserve dial to itself

* ignore ensured connections while re-connecting

* re-check after sleep

* keep protocol definition on net addresses

* decrease log level

* Revert "preserve dial to itself"

This reverts commit 0c6e0fc.

* correct func comment according to modification

Co-Authored-By: mgurevin <mehmet@gurevin.net>
* fix amino overhead computation for Tx:

- also count the fieldnum / typ3
- add method to compute overhead per Tx
- slightly clarify comment on MaxAminoOverheadForBlock
- add tests

* fix TestReapMaxBytesMaxGas according to amino overhead

* fix TestMempoolFilters according to amino overhead

* address review comments:

 - add a note about fieldNum = 1
 - add forgotten godoc comment

* fix and use sm.TxPreCheck

* fix test

* remove print statement
* changelog and version

* fix changelog
@codecov-io
Copy link

codecov-io commented Nov 11, 2018

Codecov Report

Merging #2807 into master will increase coverage by 0.04%.
The diff coverage is 59.29%.

@@            Coverage Diff             @@
##           master    #2807      +/-   ##
==========================================
+ Coverage   62.24%   62.29%   +0.04%     
==========================================
  Files         212      212              
  Lines       17184    17219      +35     
==========================================
+ Hits        10697    10727      +30     
- Misses       5588     5591       +3     
- Partials      899      901       +2
Impacted Files Coverage Δ
p2p/pex/pex_reactor.go 72.66% <0%> (-0.71%) ⬇️
libs/autofile/group.go 65.71% <0%> (-0.18%) ⬇️
config/config.go 68.77% <0%> (-0.52%) ⬇️
p2p/pex/addrbook.go 68.91% <0%> (-0.34%) ⬇️
libs/autofile/autofile.go 80.82% <0%> (+4.5%) ⬆️
p2p/pex/errors.go 0% <0%> (ø) ⬆️
consensus/reactor.go 66.97% <100%> (-0.16%) ⬇️
crypto/merkle/proof.go 40.35% <100%> (+2.16%) ⬆️
consensus/wal.go 63.63% <100%> (+0.84%) ⬆️
state/execution.go 75.11% <100%> (-0.57%) ⬇️
... and 15 more

@melekes
Copy link
Contributor

melekes commented Nov 12, 2018

@ebuchman ebuchman merged commit 80d0a36 into master Nov 12, 2018
@ebuchman ebuchman deleted the release/v0.26.1 branch November 12, 2018 13:04
ebuchman added a commit that referenced this pull request Nov 12, 2018
Merge pull request #2807 from tendermint/release/v0.26.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants