Skip to content

Merge pull request #2807 from tendermint/release/v0.26.1#2813

Merged
ebuchman merged 1 commit intodevelopfrom
master
Nov 12, 2018
Merged

Merge pull request #2807 from tendermint/release/v0.26.1#2813
ebuchman merged 1 commit intodevelopfrom
master

Conversation

@ebuchman
Copy link
Contributor

Release/v0.26.1

Merge master back to develop

@ebuchman ebuchman merged commit 0f793a5 into develop Nov 12, 2018
iKapitonau pushed a commit to scrtlabs/tendermint that referenced this pull request Jul 10, 2024
…rmint#2804) (tendermint#2813)

Followup to tendermint#2792 which closed tendermint#2771.

tendermint#2792 does not handle the case where Start is never called. If Start is
not called, Stop returns an error, thus with tendermint#2792's implementation the
only way to ensure that PingPongLatencyTimer is cleaned up is to call
Start and Stop, even when not using any of the features provided by
Start (i.e. events).

This PR moves initialization of PingPongLatencyTimer into OnStart so
that it is only initialized if it is going to be used. This PR also
moves cleanup of PingPongLatencyTimer into readRoutine's defer statement
to align it with other cleanup (i.e. closing the connection).

#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [ ] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
<hr>This is an automatic backport of pull request tendermint#2804 done by
[Mergify](https://mergify.com).

Co-authored-by: Ethan Reesor <firelizzard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant