Fix crypto/merkle ProofOperators.Verify to check bounds on keypath pa…#2756
Merged
Fix crypto/merkle ProofOperators.Verify to check bounds on keypath pa…#2756
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2756 +/- ##
===========================================
+ Coverage 62.21% 62.22% +<.01%
===========================================
Files 212 212
Lines 17136 17185 +49
===========================================
+ Hits 10661 10693 +32
- Misses 5577 5592 +15
- Partials 898 900 +2
|
melekes
reviewed
Nov 5, 2018
| for i, op := range poz { | ||
| key := op.GetKey() | ||
| if len(key) != 0 { | ||
| if len(keys) == 0 { |
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Oh damn, I was obviously wrong, since the keys were getting re-sliced and could run out before we finish looping over the poz. Very nice catch!
melekes
approved these changes
Nov 5, 2018
maxim-levy
pushed a commit
to maxim-levy/tendermint
that referenced
this pull request
Nov 13, 2018
* 'master' of https://github.com/tendermint/tendermint: (330 commits) Release/v0.26.1 (tendermint#2803) fix amino overhead computation for Tx (tendermint#2792) p2p: re-check after sleeps (tendermint#2664) check the result of `ps.peer.Send` before calling `ps.setHasVote` (tendermint#2787) p2p: AddressBook requires addresses to have IDs; Do not close conn immediately after sending pex addrs in seed mode (tendermint#2797) test AutoFile#Size (happy path) [autofile/group] do not panic when checking size openFile creates a file if not exist => ErrNotExist is not possible use our logger in autofile/group Add tests for ValidateBasic methods (tendermint#2754) [docs] improve organization of ABCI docs & fix links (tendermint#2749) p2p: peer-id -> peer_id (tendermint#2771) mempool: print postCheck error (tendermint#2762) Fix crypto/merkle ProofOperators.Verify to check bounds on keypath pa… (tendermint#2756) Mempool WAL is still created by default in home directory, leads to permission errors (tendermint#2758) mempool: ErrPreCheck and more log info (tendermint#2724) Release/v0.26.0 (tendermint#2726) [ADR] [DRAFT] pubsub 2.0 (tendermint#2532) validate reactor messages (tendermint#2711) TMHASH is 32 bytes. Closes tendermint#1990 (tendermint#2732) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Go 1.11 has issues where despite the lack of bounds checking prior to this PR, it doesn't panic at all due to a bug in 1.11. https://go-review.googlesource.com/c/go/+/132495/ . Upgrade to 1.11.2.