-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Labels
C:p2pComponent: P2P pkgComponent: P2P pkgT:bugType Bug (Confirmed)Type Bug (Confirmed)good first issueContributions Welcome!!Contributions Welcome!!
Milestone
Description
Pointed out in #2721 (comment)
module=p2p peer=0xb78f00
It's because we're passing a function pointer rather than calling the function in:
Line 619 in 6e9aee5
| p.SetLogger(sw.Logger.With("peer", p.NodeInfo().NetAddress().String)) |
We should just pass the NetAddress() there, no need to call String().
But note even if we do that, we still lose the ID. That's because in
Lines 316 to 321 in 6e9aee5
| func removeProtocolIfDefined(addr string) string { | |
| if strings.Contains(addr, "://") { | |
| return strings.Split(addr, "://")[1] | |
| } | |
| return addr | |
@, eg. 76e35576b8dd1cf8049fea382fda8ac621a9c6ee@tcp://0.0.0.0:26656. So we need fix this tooReactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C:p2pComponent: P2P pkgComponent: P2P pkgT:bugType Bug (Confirmed)Type Bug (Confirmed)good first issueContributions Welcome!!Contributions Welcome!!