if some process locks a block in round 0, then 0 is valid proposal.PO…#2704
Merged
if some process locks a block in round 0, then 0 is valid proposal.PO…#2704
Conversation
…LRound in rounds > 0 This condition is really hard to get. Initially, lockedRound and validRound are set to -1 as we start with round 0. Refs #2702
Codecov Report
@@ Coverage Diff @@
## develop #2704 +/- ##
===========================================
+ Coverage 62.21% 62.23% +0.02%
===========================================
Files 212 212
Lines 17136 17143 +7
===========================================
+ Hits 10661 10669 +8
Misses 5577 5577
+ Partials 898 897 -1
|
Contributor
|
Closing for #2735 @milosevic please confirm |
Contributor
Author
|
I think changes here make the code better&more readable (NOTE they do not fix/change anything) |
Contributor
|
Ah right, happy to bring that in, but it looks like it changes the logic to allow POLRound to equal the current round which I don't think we want. |
Contributor
Author
|
No, it will return err if |
ebuchman
approved these changes
Nov 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…LRound in rounds > 0
This condition is really hard to get. Initially, lockedRound and
validRound are set to -1 as we start with round 0.
Refs #2702