Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2735 +/- ##
===========================================
- Coverage 62.32% 62.29% -0.03%
===========================================
Files 211 211
Lines 17053 17029 -24
===========================================
- Hits 10628 10608 -20
+ Misses 5555 5552 -3
+ Partials 870 869 -1
|
a989354 to
fe04e5b
Compare
fe04e5b to
3ff909b
Compare
liamsi
reviewed
Oct 31, 2018
types/canonical.go
Outdated
| Height int64 `binary:"fixed64"` | ||
| Round int64 `binary:"fixed64"` | ||
| BlockID CanonicalBlockID | ||
| POLRound int64 `binary:"fixed64"` |
Contributor
There was a problem hiding this comment.
As far as I understand, the BlockID is not of fixed size (?). For HSMs to be able to parse the proposals, it is important that we keep the fixed sized fields in front (Type, Height, Round, POLRound, and then, BlockID, Timestamp, ChainID).
3ff909b to
e72d9e5
Compare
ebuchman
approved these changes
Oct 31, 2018
| Height int64 `json:"height"` | ||
| Round int `json:"round"` | ||
| BlockID BlockID `json:"block_id"` | ||
| POLRound int `json:"pol_round"` // -1 if null. |
Contributor
There was a problem hiding this comment.
Let's keep the order here aligned with the Canonical order, so POLRound should come before BlockID
Contributor
|
Looks good, also need to update the spec: https://github.com/tendermint/tendermint/blob/develop/docs/spec/reactors/consensus/consensus.md#proposal |
This was referenced Oct 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2646.
Note that we could easily add nice Proposal related tests after #2652 is merged.