take changes from main project#1
Merged
Merged
Conversation
Fix all checkstyle warnings and added checkstyle suppression in gen
* Remove preferences from tests * Fix tests in StyleLoader and XMPUtil * Refactor KeyBindingsPreferences to be independent from JabRefPreferences * Refactor ManageJournalAbbreviations to be independent from JabRefPreferences * Create architecture tests for Tests * Fix tests * Fix fetcher tests
More JavaFX editors
Fixes #2766 If file is not found annotations might be null
* Updated Spanish translation From import and Remove entry from import strings have been updated * Updated Spanish translation * Update Menu_es.properties * apply Translated strings from @jtornero * Run gradlew localizationUpdate
…into checkstyle # Conflicts: # src/main/java/org/jabref/gui/entryeditor/FieldExtraComponents.java # src/main/java/org/jabref/preferences/JabRefPreferences.java
…into checkstyle
Clean up checkstyle warnings
[ciskip]
* Reimplement date editor in JavaFX * Fix checkstyle issue
* Fix del/copy/paste key trigger main table action in search bar * Add comments what has to be done * checkstyle * Delete CHANGELOG.md.orig
* Add warning message if group with same name is already present (or new group name contains keyword separator) * Update localization
* Only load the telementry service as a background task, if it actually used to improve the startup duration #2966 * Make Telementry Client optional
* Fix attach file action from contextmenu Return new ArrayList instead of unmodiefable emptyList() * Add unit test * always return ArrayList * Add javadoc comment * change to early return * fix checkstyle
- Make use of gitignore.io - Add node, because of markdown-toc - Add snapcraft to prepare snapcraft-PR - Remove custom entries by entries generated by gitignore.io
* Remove redundancy * Update timestamp when entry is fetched #3074 * Unused import * Move to own preferences class * Checkstyle is a pain in the ***
* Add validation to entry editor * Fix build
* Add join and replace functionality to keyword manager. * Switch out KeyListener for KeyAdapter to so empty methods can be removed * Fix Codacy "Avoid reassigning parameter" issue.
Initial shot for snapcraft.yaml
* Store changes in source tab when new entry is selected * Remove unnecessary method parameter * Mark base panel as changed if something is typed in the source tab * Remove unused import * Remove stale comment on undo manager (undo works) * Remove stale code and comments on error messages (error messages are already implemented) * Rebuild other fields tab when fields in the source tab change * Select new OtherFieldsTab if the old one was selected before * Update localization * Fix checkstyle complaints * Rebuild other fields tab every time an other field is added or deleted * Consolidate new event types into a single type * Formatting and comment improvements * Readd OtherFieldTab only if there are other fields and delete it otherwise * Turn defaultIndex into constant
* Update SourceTab in FXApplication thread * Add Changelog entry * Make sure that the other fields tab is rebuild on the FXApplicationThread * Omit curly braces in lambdas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gradle localizationUpdate?