Enable join and replace of keywords#3094
Merged
Merged
Conversation
koppor
approved these changes
Aug 10, 2017
koppor
left a comment
Member
There was a problem hiding this comment.
LGTM. I know, that we should have it reimplemented in JavaFX, but better this implementation than nothing 😇
Member
|
There was someone in the issue who noticed a bug and wanted to Work on this. Maybe he is interested in porting to javafx? |
Siedlerchr
requested changes
Aug 10, 2017
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
Just the minor change, Rest okay
|
|
||
| // enable a user to press Enter to get a keyword added | ||
| keyword.addKeyListener(new KeyListener() { | ||
|
|
Member
There was a problem hiding this comment.
Use keyAdapter instead of key listener, so you don't need to have the empty method.
Member
|
Please have a look at the codacy issues, after that we can merge |
a431a58 to
a3fcf87
Compare
Siedlerchr
approved these changes
Aug 11, 2017
Member
|
As @koppor already approved these changes and I'm happy, too, I merge this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements #1076
gradle localizationUpdate?