Add Guava Cache to CitationStyleCache#3089
Merged
Merged
Conversation
ba6265d to
76b2f96
Compare
Siedlerchr
approved these changes
Aug 9, 2017
| this.citationStyle = citationStyle; | ||
| citationStyleCache = CacheBuilder.newBuilder().maximumSize(CACHE_SIZE).build(new CacheLoader<BibEntry, String>() { | ||
| @Override | ||
| public String load(BibEntry entry) throws Exception { |
Member
There was a problem hiding this comment.
Can this be converted to a Lambda expression?
Member
There was a problem hiding this comment.
According to https://stackoverflow.com/a/34424577/873282, this is not possible. The basic class has more than one abstract method (see https://github.com/google/guava/blob/master/guava/src/com/google/common/cache/CacheLoader.java#L127).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses Guava's Cache instead of a HashMap for caching.
This enables us to limit the number of cached entries. The current number 1024 is chosen arbitrarily. Maybe, 100 could be enough.
gradle localizationUpdate?