Skip to content

More JavaFX editors#2759

Merged
tobiasdiez merged 4 commits into
masterfrom
moreEditors
Apr 20, 2017
Merged

More JavaFX editors#2759
tobiasdiez merged 4 commits into
masterfrom
moreEditors

Conversation

@tobiasdiez

Copy link
Copy Markdown
Member

A few more field editors are reimplemented in JavaFX.
I will fix the failing language test later.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 18, 2017
@Siedlerchr

Copy link
Copy Markdown
Member

Looks okay to me. Would be nice if you could add some screenshots

@tobiasdiez tobiasdiez merged commit a9e2066 into master Apr 20, 2017
@tobiasdiez tobiasdiez deleted the moreEditors branch April 20, 2017 13:17
@stefan-kolb

stefan-kolb commented Apr 20, 2017

Copy link
Copy Markdown
Member

@JabRef/developers Whereas I like the work that is done here, it is a step back from the current UI. Some functionality is missing other functionality is not as accessible as before.
Not sure if I like that the descriptions are gone. It's not intuitive anymore what the Buttons do and the Icons are not self explaining...
We should have discussed this at least shouldn't we?

As an example:
Before:
image

After:
image

@Siedlerchr

Copy link
Copy Markdown
Member

@stefan-kolb I think the buttons are now setup as icons here.

@lenhard

lenhard commented Apr 20, 2017

Copy link
Copy Markdown
Member

I agree with Stefan. It seems that the crossref, file, and timestamp field editors are missing certain functions.

Also if the text on the buttons is gone, then we at least need the tool tips.

@tobiasdiez

tobiasdiez commented Apr 20, 2017

Copy link
Copy Markdown
Member Author

@stefan-kolb as outlined in the previous PR, I will convert each editor peu à peu and in the end the full functionality should be restored. For the text buttons vs icons, we should probably discuss this in the devcall.
The icons have indeed tooltips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants