Fixes handling of unknown PDAnnotation types.#2778
Merged
Conversation
tobiasdiez
approved these changes
Apr 21, 2017
| * @param annotation the raw PDAnnotation | ||
| * @return The determined FileAnnotationType | ||
| */ | ||
| public static FileAnnotationType parseFileAnnotationType(PDAnnotation annotation) { |
Member
There was a problem hiding this comment.
I think we normally called such methods simply parse since the rest should be clear from the class name. But you can leave it also like that.
koppor
approved these changes
Apr 21, 2017
Member
|
Please change method name, resolve the conflict and then merge. |
stefan-kolb
approved these changes
Apr 22, 2017
| NONE("None"); | ||
|
|
||
| private final String name; | ||
| private static final Log LOGGER = LogFactory.getLog(FileAnnotationType.class); |
Member
There was a problem hiding this comment.
Please put the logger attribute directly under the enum declaration.
|
|
||
| private final String name; | ||
| private static final Log LOGGER = LogFactory.getLog(FileAnnotationType.class); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs. #2777