Fix Drag and drop of file by first converting to File and then to path#2764
Merged
Conversation
tobiasdiez
requested changes
Apr 19, 2017
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
Can we convert DataFlavor.javaFileListFlavor to always use Paths instead of Files? If not, then the fix looks good to me.
Member
Author
|
I don't think is possible as this is some internal java definition in the
background which all work on File instead path
Otherwise the cast would have been Successful at first
Am 19.04.2017 3:54 nachm. schrieb "Tobias Diez" <notifications@github.com>:
… ***@***.**** requested changes on this pull request.
Can we convert DataFlavor.javaFileListFlavor to always use Paths instead
of Files? If not, then the fix looks good to me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2764 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AATi5IG5sg3VJNrQCKqPn2qpkOYuDblIks5rxhIjgaJpZM4NBoP_>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #2760
Internal change only. Was introduced by fa6e074