Store changes in source tab when new entry is selected#3097
Merged
Conversation
Siedlerchr
approved these changes
Aug 11, 2017
…already implemented)
Siedlerchr
reviewed
Aug 12, 2017
| OtherFieldsTab tab = new OtherFieldsTab(frame, panel, entryType, this, entry); | ||
| if (tab.getFields().size() > 0) { | ||
| // add it at default index, but that is just a guess | ||
| int defaultIndex = 4; |
Member
There was a problem hiding this comment.
Please add a constant for the magic number
Siedlerchr
approved these changes
Aug 12, 2017
matthiasgeiger
approved these changes
Aug 13, 2017
matthiasgeiger
left a comment
Member
There was a problem hiding this comment.
Looks good to me and also works ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3086
The problem was that the source tab only stored changes on focus change and this did not happen when you just select a new entry in the main table.
The PR modifies an attribute in the
EntryEditor(movingToDifferentEntry) and turns it into aBooleanPropertyso that you can bind to it and react to changes.EDIT: Also fixes a second (unreported) issue: Now the base panel is marked as dirty when you type something in the source tab.
EDIT 2: Fixes also #3063
Now the Other fields tab is rebuilt whenever an other field is newly added or removed at the BibEntry. This is achieved with the event system and a new subtype of FieldChangedEvent.
gradle localizationUpdate?