Conversation
Comment on lines
+644
to
+648
| newConns := make([]*connEntry, numCurrent+n) | ||
| copy(newConns, currentConns) | ||
| copy(newConns[numCurrent:], newEntries[:n]) | ||
| p.conns.Store(newConns) | ||
| btopt.Debugf(p.logger, "bigtable_connpool: Added %d connections, new size: %d\n", n, len(newConns)) |
There was a problem hiding this comment.
this seems to still have the same problem as we discussed ... you are exposing unprimed channels to the pool.
How about adding a wait group for all of the goroutines and waiting on all of the to finish?
| index int | ||
| } | ||
|
|
||
| // removeConnections returns true if the pool size changed. |
There was a problem hiding this comment.
please expand the comment explaining which connections will be targeted for removal
|
|
||
| dynamicConfig btopt.DynamicChannelPoolConfig // Keep the config for options | ||
| // background monitors | ||
| monitors []Monitor |
There was a problem hiding this comment.
The relationship between a pool and a monitor is very murky. It seems like a Monitor should know about a pool and control the pool. But for some reason the pool owns the references to the monitor? Why not have the client own struct own it and have a cleaner separation?
Owner
Author
There was a problem hiding this comment.
--> Why not have the client own struct own it and have a cleaner separation?
yeah it is murky.
what do you prefer?
-
client owning the reference to the monitor and controlling the pool.
-
or passing the functions instead of the entire pool reference to the monitor? similar to the MetricsExporter
NewDynamicScaleMonitor(
pool.dynamicConfig,
pool.ConnectionLoadStatsSuppolier,
pool.addConnections,
pool.removeConnections,
)
9cc5825 to
57713c3
Compare
igorbernstein2
approved these changes
Dec 3, 2025
sushanb
added a commit
that referenced
this pull request
Dec 21, 2025
* WIP * WIO * Fix * Address feedback * remove alts * FIX * WIO * WIP * WIP * Make conn draining timeout 30mins * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * Review comments * WIP * WIP * go2 complete
sushanb
added a commit
that referenced
this pull request
Dec 21, 2025
* WIP * WIO * Fix * Address feedback * remove alts * FIX * WIO * WIP * WIP * Make conn draining timeout 30mins * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * Review comments * WIP * WIP * go2 complete
sushanb
added a commit
to googleapis/google-cloud-go
that referenced
this pull request
Dec 22, 2025
Cherrypick of sushanb#2 THe commit id is sushanb@8579aed The delta is same (+933, -4) ``` curl -L https://github.com/sushanb/google-cloud-go/commit/8579aedcf260adbe4da811b7075242a2bbd3fdd7.patch -o fix.patch git am fix.patch ```
sushanb
pushed a commit
that referenced
this pull request
Feb 6, 2026
…3782) PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.8.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:01189c9771ac4150742aed38eb52e19a008018889066002742034b7f82db070f <details><summary>bigtable: 1.42.0</summary> ## [1.42.0](googleapis/google-cloud-go@bigtable/v1.41.0...bigtable/v1.42.0) (2026-02-04) ### Features * add TieredStorageConfig to table admin api (PiperOrigin-RevId: 863493708) ([611f239](googleapis@611f2392)) * add dynamic channel support (#2) (googleapis#13504) ([65a3c4e](googleapis@65a3c4ec)) * add ip protocol for bigtable connection (googleapis#13520) ([6f86983](googleapis@6f86983e)) * add metrics exporter for outstandingrpcs and perconnectionerror count (googleapis#13510) ([7f1b36a](googleapis@7f1b36ac)) * add client startup time metrics. (googleapis#13521) ([8f90da3](googleapis@8f90da38)) * introduce prime() method and load counting based on unary,streaming and ability to remove connection (googleapis#13419) ([c6773ce](googleapis@c6773ceb)) ### Bug Fixes * handle client region and client host name based on ote… (googleapis#13752) ([0429170](googleapis@0429170f)) * fix a nil pointer deference in remove connections when… (googleapis#13535) ([9d2ba82](googleapis@9d2ba82e)) ### Performance Improvements * use passthrough with emulator endpoint (googleapis#13739) ([dafbca2](googleapis@dafbca22)) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.