Skip to content

perf(bigtable): use passthrough with emulator endpoint#13739

Merged
bhshkh merged 2 commits intogoogleapis:mainfrom
bhshkh:perf/cbt-emulator-passthrough
Jan 28, 2026
Merged

perf(bigtable): use passthrough with emulator endpoint#13739
bhshkh merged 2 commits intogoogleapis:mainfrom
bhshkh:perf/cbt-emulator-passthrough

Conversation

@bhshkh
Copy link
Copy Markdown
Contributor

@bhshkh bhshkh commented Jan 28, 2026

Fixes #10965

This change updates the Bigtable client to use the passthrough:/// scheme when connecting to the emulator via BIGTABLE_EMULATOR_HOST.

This ensures consistent behavior with other Google Cloud Go clients (e.g., Spanner #10947) and avoids potential gRPC name resolution issues by forcing the passthrough resolver. It handles BIGTABLE_EMULATOR_HOST values with or without an existing scheme (e.g. localhost:9000 or http://localhost:9000).

@bhshkh bhshkh requested review from a team January 28, 2026 15:33
@bhshkh bhshkh requested a review from a team as a code owner January 28, 2026 15:33
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jan 28, 2026
@bhshkh bhshkh enabled auto-merge (squash) January 28, 2026 15:34
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Jan 28, 2026

Summary of Changes

Hello @bhshkh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the Bigtable client's emulator connection logic by enforcing the use of the passthrough:/// scheme. This standardization addresses potential gRPC name resolution inconsistencies and aligns the Bigtable client with the connection practices of other Google Cloud Go clients, leading to more reliable emulator interactions.

Highlights

  • Emulator Connection Scheme: The Bigtable client now explicitly uses the "passthrough:///" scheme when connecting to the emulator via BIGTABLE_EMULATOR_HOST. This change ensures consistent behavior with other Google Cloud Go clients and avoids potential gRPC name resolution issues by forcing the passthrough resolver.
  • Scheme Handling: The implementation now robustly handles BIGTABLE_EMULATOR_HOST values, stripping any existing scheme (e.g., http://, https://, or passthrough:///) before applying the passthrough:/// prefix, ensuring the address is always correctly formatted for the passthrough resolver.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the Bigtable client to use the passthrough:/// scheme for emulator connections, ensuring consistent behavior and preventing potential gRPC name resolution issues. The implementation is sound, and the suggested performance optimization related to regular expression compilation is noted.

@bhshkh bhshkh merged commit dafbca2 into googleapis:main Jan 28, 2026
12 checks passed
@bhshkh bhshkh deleted the perf/cbt-emulator-passthrough branch January 28, 2026 17:55
@bhshkh bhshkh mentioned this pull request Feb 4, 2026
Merged
bhshkh added a commit that referenced this pull request Feb 4, 2026
@bhshkh
chore: librarian release pull request: 20260204T190438Z (#13782)
c84fd39 
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.8.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:01189c9771ac4150742aed38eb52e19a008018889066002742034b7f82db070f
<details><summary>bigtable: 1.42.0</summary>

##
[1.42.0](bigtable/v1.41.0...bigtable/v1.42.0)
(2026-02-04)

### Features

* add TieredStorageConfig to table admin api (PiperOrigin-RevId:
863493708)
([611f239](611f2392))

* add dynamic channel support (#2) (#13504)
([65a3c4e](65a3c4ec))

* add ip protocol for bigtable connection (#13520)
([6f86983](6f86983e))

* add metrics exporter for outstandingrpcs and perconnectionerror count
(#13510)
([7f1b36a](7f1b36ac))

* add client startup time metrics. (#13521)
([8f90da3](8f90da38))

* introduce prime() method and load counting based on unary,streaming
and ability to remove connection (#13419)
([c6773ce](c6773ceb))

### Bug Fixes

* handle client region and client host name based on ote… (#13752)
([0429170](0429170f))

* fix a nil pointer deference in remove connections when… (#13535)
([9d2ba82](9d2ba82e))

### Performance Improvements

* use passthrough with emulator endpoint (#13739)
([dafbca2](dafbca22))

</details>
@apstndb apstndb mentioned this pull request Mar 7, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman shollyman approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bigtable: use passthrough with emulator endpoint

2 participants

@bhshkh @shollyman