Skip to content

feat(bigtable): add dynamic channel support (#2)#13504

Merged
sushanb merged 2 commits intogoogleapis:mainfrom
sushanb:fix-bigtable-transport
Dec 22, 2025
Merged

feat(bigtable): add dynamic channel support (#2)#13504
sushanb merged 2 commits intogoogleapis:mainfrom
sushanb:fix-bigtable-transport

Conversation

@sushanb
Copy link
Copy Markdown
Contributor

@sushanb sushanb commented Dec 21, 2025

Cherrypick of sushanb#2

THe commit id is sushanb@8579aed

The delta is same (+933, -4)

curl -L https://github.com/sushanb/google-cloud-go/commit/8579aedcf260adbe4da811b7075242a2bbd3fdd7.patch -o fix.patch
git am fix.patch

@sushanb
READY feat(bigtable) : add dynamic channel support (#2)
58532fc 
* WIP

* WIO

* Fix

* Address feedback

* remove alts

* FIX

* WIO

* WIP

* WIP

* Make conn draining timeout 30mins

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* Review comments

* WIP

* WIP

* go2 complete
@sushanb sushanb requested review from a team and igorbernstein2 December 21, 2025 21:04
@sushanb sushanb requested a review from a team as a code owner December 21, 2025 21:04
@sushanb sushanb changed the title READY feat(bigtable) : add dynamic channel support (#2) feat(bigtable) : add dynamic channel support (#2) Dec 21, 2025
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Dec 21, 2025

Summary of Changes

Hello @sushanb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the Bigtable client by implementing dynamic channel scaling. This feature allows the client's connection pool to intelligently adapt its size to the application's workload, automatically adding more connections during high demand and reducing them during low usage. This ensures optimal resource utilization, reduces operational overhead, and maintains efficient performance under varying load conditions.

Highlights

  • Dynamic Channel Scaling: Introduced dynamic channel scaling for the Bigtable client, allowing the connection pool to automatically adjust its size based on current load.
  • DynamicScaleMonitor: Added a new DynamicScaleMonitor component responsible for evaluating connection pool load and triggering scale-up or scale-down operations.
  • Configuration Options: New configuration options (EnableDynamicChannelPool in ClientConfig and DynamicChannelPoolConfig struct) are available to control the behavior of dynamic scaling, including min/max connections and load thresholds.
  • Connection Age Tracking: Connections within the pool now track their creation time, enabling the removeConnections logic to prioritize and remove older connections during scale-down events.
  • Testing: Comprehensive test cases have been added for the new addConnections and removeConnections methods in the connection pool, as well as for the DynamicScaleMonitor itself, covering various scaling scenarios and edge cases.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces dynamic channel pool scaling, a significant feature that allows the Bigtable client to adjust its connection pool size based on load. The implementation includes a DynamicScaleMonitor, configuration options, and modifications to the connection pool to support adding and removing connections. While the overall approach is sound, I've identified a couple of critical issues, including one that will cause a compilation error and another that could lead to a runtime panic. I've also noted a high-severity performance concern regarding lock contention and a medium-severity issue with an unused function parameter. Addressing these points will be crucial for the stability and performance of this new feature.

@sushanb sushanb changed the title feat(bigtable) : add dynamic channel support (#2) feat(bigtable): add dynamic channel support (#2) Dec 21, 2025
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Dec 22, 2025
@sushanb sushanb merged commit 65a3c4e into googleapis:main Dec 22, 2025
11 checks passed
@sushanb sushanb deleted the fix-bigtable-transport branch December 22, 2025 19:40
@bhshkh bhshkh mentioned this pull request Jan 8, 2026
Closed
@bhshkh bhshkh mentioned this pull request Feb 4, 2026
Merged
bhshkh added a commit that referenced this pull request Feb 4, 2026
@bhshkh
chore: librarian release pull request: 20260204T190438Z (#13782)
c84fd39 
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.8.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:01189c9771ac4150742aed38eb52e19a008018889066002742034b7f82db070f
<details><summary>bigtable: 1.42.0</summary>

##
[1.42.0](bigtable/v1.41.0...bigtable/v1.42.0)
(2026-02-04)

### Features

* add TieredStorageConfig to table admin api (PiperOrigin-RevId:
863493708)
([611f239](611f2392))

* add dynamic channel support (#2) (#13504)
([65a3c4e](65a3c4ec))

* add ip protocol for bigtable connection (#13520)
([6f86983](6f86983e))

* add metrics exporter for outstandingrpcs and perconnectionerror count
(#13510)
([7f1b36a](7f1b36ac))

* add client startup time metrics. (#13521)
([8f90da3](8f90da38))

* introduce prime() method and load counting based on unary,streaming
and ability to remove connection (#13419)
([c6773ce](c6773ceb))

### Bug Fixes

* handle client region and client host name based on ote… (#13752)
([0429170](0429170f))

* fix a nil pointer deference in remove connections when… (#13535)
([9d2ba82](9d2ba82e))

### Performance Improvements

* use passthrough with emulator endpoint (#13739)
([dafbca2](dafbca22))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sushanb @igorbernstein2