Skip to content

feat(bigtable): add metrics exporter for outstandingrpcs and perconnectionerror count #13510

Merged
sushanb merged 3 commits intogoogleapis:mainfrom
sushanb:exporter-metrics
Dec 22, 2025
Merged

feat(bigtable): add metrics exporter for outstandingrpcs and perconnectionerror count #13510
sushanb merged 3 commits intogoogleapis:mainfrom
sushanb:exporter-metrics

Conversation

@sushanb
Copy link
Copy Markdown
Contributor

@sushanb sushanb commented Dec 22, 2025 •
edited
Loading

lift and shift of sushanb#3

curl -L -O https://github.com/sushanb/google-cloud-go/commit/b9d20984c514b4632f7c613e4d6ab58b1776a939.patch
git apply b9d20984c514b4632f7c613e4d6ab58b1776a939.patch

@sushanb sushanb requested review from a team and igorbernstein2 December 22, 2025 20:51
@sushanb sushanb requested a review from a team as a code owner December 22, 2025 20:51
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Dec 22, 2025
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Dec 22, 2025

Summary of Changes

Hello @sushanb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Bigtable client library by integrating OpenTelemetry-based metrics reporting for its internal connection pool. The primary goal is to provide deeper operational insights into the client's behavior by tracking key performance indicators such as outstanding RPCs and connection-specific error rates. This allows for better monitoring and debugging of client-side performance and reliability.

Highlights

  • New Metrics Reporting: Introduced a new MetricsReporter to periodically collect and export connection pool statistics using OpenTelemetry.
  • Tracked Metrics: The new metrics include 'outstanding RPCs' per connection (unary and streaming) and 'per-connection error count'.
  • Configuration Options: Added MetricsReporterConfig to control whether metrics reporting is enabled and its reporting interval, with a default of 1 minute.
  • Integration with Connection Pool: The BigtableChannelPool now initializes and manages the MetricsReporter, starting it when the pool is created and stopping it when the pool is closed.
  • OpenTelemetry Integration: The metrics are exported as OpenTelemetry Float64Histograms, with attributes like transport_type (cloudpath/directpath) and lb_policy.
  • Error Count Reset: The per-connection error count is reset to zero after each reporting interval to capture errors per period.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a metrics exporter to the Bigtable client to report outstanding RPCs and per-connection error counts. The changes involve adding a MetricsReporter that periodically collects and exports these metrics via OpenTelemetry. My review focuses on improving code correctness, efficiency, and maintainability. I've pointed out an incorrect package name, some redundant code that can be simplified, a potential performance improvement by pre-creating attribute sets, and some corrections in the tests to make them clearer and more accurate. Overall, this is a valuable addition for monitoring client health.

@sushanb sushanb changed the title feat(bigtable): add metrics exporter export outstandingrpcs and perconnectionerror count feat(bigtable): add metrics exporter for outstandingrpcs and perconnectionerror count Dec 22, 2025
@sushanb sushanb merged commit 7f1b36a into googleapis:main Dec 22, 2025
11 checks passed
@bhshkh bhshkh mentioned this pull request Jan 8, 2026
Closed
@bhshkh bhshkh mentioned this pull request Feb 4, 2026
Merged
bhshkh added a commit that referenced this pull request Feb 4, 2026
@bhshkh
chore: librarian release pull request: 20260204T190438Z (#13782)
c84fd39 
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.8.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:01189c9771ac4150742aed38eb52e19a008018889066002742034b7f82db070f
<details><summary>bigtable: 1.42.0</summary>

##
[1.42.0](bigtable/v1.41.0...bigtable/v1.42.0)
(2026-02-04)

### Features

* add TieredStorageConfig to table admin api (PiperOrigin-RevId:
863493708)
([611f239](611f2392))

* add dynamic channel support (#2) (#13504)
([65a3c4e](65a3c4ec))

* add ip protocol for bigtable connection (#13520)
([6f86983](6f86983e))

* add metrics exporter for outstandingrpcs and perconnectionerror count
(#13510)
([7f1b36a](7f1b36ac))

* add client startup time metrics. (#13521)
([8f90da3](8f90da38))

* introduce prime() method and load counting based on unary,streaming
and ability to remove connection (#13419)
([c6773ce](c6773ceb))

### Bug Fixes

* handle client region and client host name based on ote… (#13752)
([0429170](0429170f))

* fix a nil pointer deference in remove connections when… (#13535)
([9d2ba82](9d2ba82e))

### Performance Improvements

* use passthrough with emulator endpoint (#13739)
([dafbca2](dafbca22))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sushanb @igorbernstein2