READY feat(bigtable): add metrics exporter in the client to export outstandingrpcs and perconnectionerror count#3
Merged
Conversation
| } | ||
| baseAttrSet := attribute.NewSet(baseAttrs...) | ||
|
|
||
| if mr.outstandingRPCsHistogram != nil { |
There was a problem hiding this comment.
There are too many signals for things being disabled and having a partial working state. Please reduce the number of states to 3:
- stats enabled and everything being exported
- stats disabled and nothing being exported
- stats enabled but there is a failure for creating meters, fail creating the client.
Owner
Author
There was a problem hiding this comment.
Done.
stats enabled but there is a failure for creating meters, fail creating the client.
--> instead of failing client, i did not start the metrics Exporter.
9cc5825 to
57713c3
Compare
Comment on lines
+133
to
+136
| transportType := "cloudpath" | ||
| if stat.IsALTSUsed { | ||
| transportType = "directpath" | ||
| } |
There was a problem hiding this comment.
i mentioned this in the parent pr, but I think you wanna disambiguate no connection from cloudpath
Owner
Author
There was a problem hiding this comment.
Will do it as pr in main branch.
igorbernstein2
approved these changes
Dec 3, 2025
sushanb
added a commit
to googleapis/google-cloud-go
that referenced
this pull request
Dec 22, 2025
…ctionerror count (#13510) lift and shift of sushanb#3 ``` curl -L -O https://github.com/sushanb/google-cloud-go/commit/b9d20984c514b4632f7c613e4d6ab58b1776a939.patch git apply b9d2098.patch ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.