Skip to content

fix(bigtable): handle client region and client host name based on ote…#13752

Merged
sushanb merged 1 commit intogoogleapis:mainfrom
sushanb:fix_m
Feb 3, 2026
Merged

fix(bigtable): handle client region and client host name based on ote…#13752
sushanb merged 1 commit intogoogleapis:mainfrom
sushanb:fix_m

Conversation

@sushanb
Copy link
Copy Markdown
Contributor

@sushanb sushanb commented Feb 2, 2026

…l conventions

@sushanb sushanb requested review from a team, bhshkh and nimf February 2, 2026 16:39
@sushanb sushanb requested a review from a team as a code owner February 2, 2026 16:39
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Feb 2, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Feb 2, 2026

Summary of Changes

Hello @sushanb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the OpenTelemetry metric attribute collection for Bigtable clients by implementing more sophisticated logic for identifying the client's host name and region. These changes align with OpenTelemetry semantic conventions, ensuring that the generated telemetry data is more precise and informative, thereby enhancing the observability of Bigtable client applications across diverse deployment environments.

Highlights

  • Enhanced Host Name Resolution: The logic for determining the client's host name (hostName) has been improved to prioritize host.name, then fallback to k8s.pod.name, and finally k8s.node.name if previous attributes are not found. This provides more accurate host identification in containerized environments.
  • Improved Region Determination: The client's region (region) is now derived more robustly. It first checks cloud.region and if that's absent, it attempts to extract the region from cloud.availability_zone (e.g., 'us-central1' from 'us-central1-a'). If no region can be determined, it defaults to 'global'.
  • New Test Coverage: A new test suite, TestOtelMetricsSchema, has been added to validate the updated hostName and region derivation logic across various scenarios, including different cloud platforms and Kubernetes contexts.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the OpenTelemetry metrics by adding more sophisticated logic to determine the client's region and hostname, following OpenTelemetry semantic conventions. The changes introduce fallback mechanisms, for instance, using Kubernetes pod or node names for the hostname, and deriving the region from the availability zone.

My review has identified a couple of areas for improvement:

  • A misleading comment in the region derivation logic and a related inconsistency in a test case.
  • A redundant comment in the hostname determination logic.

These are minor points in an otherwise solid implementation. Addressing them will improve the code's clarity and maintainability.

nimf
nimf approved these changes Feb 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@nimf nimf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sushanb sushanb merged commit 0429170 into googleapis:main Feb 3, 2026
10 of 14 checks passed
@sushanb sushanb deleted the fix_m branch February 3, 2026 02:24
@bhshkh bhshkh mentioned this pull request Feb 4, 2026
Merged
bhshkh added a commit that referenced this pull request Feb 4, 2026
@bhshkh
chore: librarian release pull request: 20260204T190438Z (#13782)
c84fd39 
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.8.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:01189c9771ac4150742aed38eb52e19a008018889066002742034b7f82db070f
<details><summary>bigtable: 1.42.0</summary>

##
[1.42.0](bigtable/v1.41.0...bigtable/v1.42.0)
(2026-02-04)

### Features

* add TieredStorageConfig to table admin api (PiperOrigin-RevId:
863493708)
([611f239](611f2392))

* add dynamic channel support (#2) (#13504)
([65a3c4e](65a3c4ec))

* add ip protocol for bigtable connection (#13520)
([6f86983](6f86983e))

* add metrics exporter for outstandingrpcs and perconnectionerror count
(#13510)
([7f1b36a](7f1b36ac))

* add client startup time metrics. (#13521)
([8f90da3](8f90da38))

* introduce prime() method and load counting based on unary,streaming
and ability to remove connection (#13419)
([c6773ce](c6773ceb))

### Bug Fixes

* handle client region and client host name based on ote… (#13752)
([0429170](0429170f))

* fix a nil pointer deference in remove connections when… (#13535)
([9d2ba82](9d2ba82e))

### Performance Improvements

* use passthrough with emulator endpoint (#13739)
([dafbca2](dafbca22))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nimf nimf nimf approved these changes

@bhshkh bhshkh Awaiting requested review from bhshkh

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sushanb @nimf