Skip to content

fix(bigtable): fix a nil pointer deference in remove connections when…#13535

Merged
sushanb merged 1 commit intogoogleapis:mainfrom
sushanb:fix_bug
Jan 5, 2026
Merged

fix(bigtable): fix a nil pointer deference in remove connections when…#13535
sushanb merged 1 commit intogoogleapis:mainfrom
sushanb:fix_bug

Conversation

@sushanb
Copy link
Copy Markdown
Contributor

@sushanb sushanb commented Jan 4, 2026

… one conn is being drained

@sushanb sushanb requested review from a team and nimf January 4, 2026 21:03
@sushanb sushanb requested a review from a team as a code owner January 4, 2026 21:03
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jan 4, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Jan 4, 2026

Summary of Changes

Hello @sushanb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the Bigtable client's connection pool management. It fixes a nil pointer dereference that could occur in the removeConnections function when processing connections, specifically when some connections were already in a draining state. The change ensures the connection pool operates robustly by correctly handling slice population, thereby preventing crashes during connection cleanup and enhancing application stability.

Highlights

  • Nil Pointer Dereference Fix: Resolved a potential nil pointer dereference within the removeConnections function of the Bigtable connection pool. This occurred when a connection was already draining, leading to uninitialized entries in a slice.
  • Slice Initialization Logic: The entries slice in removeConnections is now initialized with a zero length and populated using append, ensuring that only valid entryWithAge objects are added and preventing uninitialized elements.
  • New Test Case: A new test case, MixedDrainingState, has been added to connpool_test.go to specifically validate the correct behavior of removeConnections when the pool contains a mix of draining and active connections.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a potential nil pointer dereference in removeConnections that could occur when the connection pool contains draining connections. The fix correctly filters the list of connections to consider for removal by using append to build a new slice, which is a robust and idiomatic approach in Go. This prevents nil entries that caused the original bug. A new test case, MixedDrainingState, is also added to ensure the fix works as expected and prevents future regressions. The changes are correct and improve the stability of the connection pool logic.

@sushanb sushanb merged commit 9d2ba82 into googleapis:main Jan 5, 2026
11 checks passed
@sushanb sushanb deleted the fix_bug branch January 6, 2026 23:54
@bhshkh bhshkh mentioned this pull request Jan 8, 2026
Closed
@bhshkh bhshkh mentioned this pull request Feb 4, 2026
Merged
bhshkh added a commit that referenced this pull request Feb 4, 2026
@bhshkh
chore: librarian release pull request: 20260204T190438Z (#13782)
c84fd39 
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.8.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:01189c9771ac4150742aed38eb52e19a008018889066002742034b7f82db070f
<details><summary>bigtable: 1.42.0</summary>

##
[1.42.0](bigtable/v1.41.0...bigtable/v1.42.0)
(2026-02-04)

### Features

* add TieredStorageConfig to table admin api (PiperOrigin-RevId:
863493708)
([611f239](611f2392))

* add dynamic channel support (#2) (#13504)
([65a3c4e](65a3c4ec))

* add ip protocol for bigtable connection (#13520)
([6f86983](6f86983e))

* add metrics exporter for outstandingrpcs and perconnectionerror count
(#13510)
([7f1b36a](7f1b36ac))

* add client startup time metrics. (#13521)
([8f90da3](8f90da38))

* introduce prime() method and load counting based on unary,streaming
and ability to remove connection (#13419)
([c6773ce](c6773ceb))

### Bug Fixes

* handle client region and client host name based on ote… (#13752)
([0429170](0429170f))

* fix a nil pointer deference in remove connections when… (#13535)
([9d2ba82](9d2ba82e))

### Performance Improvements

* use passthrough with emulator endpoint (#13739)
([dafbca2](dafbca22))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nimf nimf nimf approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sushanb @nimf