Skip to content

feat(rust): pass NormalizedOutputOptions in generateBundle hook#2902

Merged
hyf0 merged 1 commit intomainfrom
11-24-refactor_rust_pass_normalizedoutputoptions_in_generatebundle_hook
Nov 24, 2024
Merged

feat(rust): pass NormalizedOutputOptions in generateBundle hook#2902
hyf0 merged 1 commit intomainfrom
11-24-refactor_rust_pass_normalizedoutputoptions_in_generatebundle_hook

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Nov 24, 2024 •
edited
Loading

Description

Let me also closes #1041, I'll create a new one to keep everything update-to-date.

This was referenced Nov 24, 2024
Merged
Merged
Merged
Merged
@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Nov 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 mentioned this pull request Nov 24, 2024
Merged
@hyf0 hyf0 marked this pull request as ready for review November 24, 2024 13:25
@hyf0 hyf0 force-pushed the 11-24-refactor_rust_pass_normalizedoutputoptions_in_generatebundle_hook branch from 185ed3e to 6735083 Compare November 24, 2024 13:25
@hyf0 hyf0 changed the title refactor(rust): pass NormalizedOutputOptions in generateBundle hook feat(rust): pass NormalizedOutputOptions in generateBundle hook Nov 24, 2024
@hyf0 hyf0 force-pushed the 11-24-refactor_rust_pass_normalizedoutputoptions_in_generatebundle_hook branch from 6735083 to 360ea3c Compare November 24, 2024 13:29
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 24, 2024 •
edited
Loading

Benchmarks Rust

  • target: main(788d7fc)
  • pr: 11-24-refactor_rust_pass_normalizedoutputoptions_in_generatebundle_hook(b74ad3c)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     84.6±1.34ms        ? ?/sec    1.00     84.4±1.89ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00    113.7±2.09ms        ? ?/sec    1.01    114.5±2.88ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.03    131.5±2.55ms        ? ?/sec    1.00    127.8±3.00ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     92.9±1.79ms        ? ?/sec    1.00     93.3±2.68ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    141.1±1.85ms        ? ?/sec    1.01    141.8±4.20ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.05    302.6±6.97ms        ? ?/sec    1.00    287.5±8.48ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.01    338.8±7.88ms        ? ?/sec    1.00    334.0±9.34ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.02    155.9±3.38ms        ? ?/sec    1.00    153.2±2.49ms        ? ?/sec
bundle/bundle@threejs                                               1.00     42.5±2.30ms        ? ?/sec    1.01     42.7±1.87ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00    111.1±4.17ms        ? ?/sec    1.09    121.5±6.11ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    128.5±2.07ms        ? ?/sec    1.04    134.0±5.44ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     53.5±1.14ms        ? ?/sec    1.02     54.6±1.57ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    433.8±6.23ms        ? ?/sec    1.01    437.8±5.36ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00  1340.6±10.89ms        ? ?/sec    1.01   1354.8±9.77ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.01  1579.9±14.88ms        ? ?/sec    1.00  1567.8±13.84ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    507.6±5.12ms        ? ?/sec    1.02    518.5±5.99ms        ? ?/sec
remapping/remapping                                                 1.00     29.5±0.29ms        ? ?/sec    1.01     29.7±0.35ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     78.0±0.57ms        ? ?/sec    1.02     79.4±0.42ms        ? ?/sec
scan/scan@rome-ts                                                   1.00    113.0±2.07ms        ? ?/sec    1.00    113.5±1.63ms        ? ?/sec
scan/scan@threejs                                                   1.02     33.0±1.98ms        ? ?/sec    1.00     32.4±2.47ms        ? ?/sec
scan/scan@threejs10x                                                1.00    315.0±3.99ms        ? ?/sec    1.00    315.3±8.91ms        ? ?/sec

Base automatically changed from 11-24-refactor_rust_add_hookgeneratebundleargs_ to main November 24, 2024 15:41
@hyf0 hyf0 force-pushed the 11-24-refactor_rust_pass_normalizedoutputoptions_in_generatebundle_hook branch from 360ea3c to 98706d7 Compare November 24, 2024 15:42
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 24, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit b74ad3c
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/67434c91f67d7c000863be9a

@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Nov 24, 2024

Merge activity

  • Nov 24, 10:42 AM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@hyf0 hyf0 force-pushed the 11-24-refactor_rust_pass_normalizedoutputoptions_in_generatebundle_hook branch from 98706d7 to b74ad3c Compare November 24, 2024 15:55
@hyf0 hyf0 mentioned this pull request Nov 24, 2024
Merged
@hyf0 hyf0 added this pull request to the merge queue Nov 24, 2024
Merged via the queue into main with commit 87f7277 Nov 24, 2024
@hyf0 hyf0 deleted the 11-24-refactor_rust_pass_normalizedoutputoptions_in_generatebundle_hook branch November 24, 2024 16:16
@hyf0 hyf0 mentioned this pull request Nov 24, 2024
Closed
@sapphi-red sapphi-red mentioned this pull request Nov 25, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 25, 2024
@sapphi-red
feat(rust): pass NormalizedOutputOptions in renderChunk hook (#2909)
b6dc60a 
<!-- Thank you for contributing! -->

### Description

This was needed for Vite.

refs #2902, #2906

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement NormalizedInputOptions and NormalizedOutputOptions to rust side

2 participants

@hyf0 @IWANABETHATGUY