Skip to content

feat(node/rollup-compat): Be compatable with rollup's NormalizedOutputOptions#format#2900

Merged
hyf0 merged 1 commit intomainfrom
11-24-feat_node_rollup-compat_be_compatable_with_rollup_s_normalizedoutputoptions_format_
Nov 24, 2024
Merged

feat(node/rollup-compat): Be compatable with rollup's NormalizedOutputOptions#format#2900
hyf0 merged 1 commit intomainfrom
11-24-feat_node_rollup-compat_be_compatable_with_rollup_s_normalizedoutputoptions_format_

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Nov 24, 2024 •
edited
Loading

Description

Closes #2867.

Notice this PR includes app format

@hyf0 hyf0 marked this pull request as ready for review November 24, 2024 12:45
This was referenced Nov 24, 2024
Merged
Merged
@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Nov 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 mentioned this pull request Nov 24, 2024
Merged
@hyf0 hyf0 force-pushed the 11-24-feat_rust_pass_normalizedoutputoptions_from_rust_to_js branch from 5b75747 to 15fc31a Compare November 24, 2024 12:52
@hyf0 hyf0 force-pushed the 11-24-feat_node_rollup-compat_be_compatable_with_rollup_s_normalizedoutputoptions_format_ branch from 391ed60 to b33df4a Compare November 24, 2024 12:52
@hyf0 hyf0 force-pushed the 11-24-feat_rust_pass_normalizedoutputoptions_from_rust_to_js branch from 15fc31a to cf0644c Compare November 24, 2024 13:04
@hyf0 hyf0 force-pushed the 11-24-feat_node_rollup-compat_be_compatable_with_rollup_s_normalizedoutputoptions_format_ branch from b33df4a to 9794f7a Compare November 24, 2024 13:04
@hyf0 hyf0 mentioned this pull request Nov 24, 2024
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 24, 2024 •
edited
Loading

Benchmarks Rust

  • target: main(ac28e50)
  • pr: 11-24-feat_node_rollup-compat_be_compatable_with_rollup_s_normalizedoutputoptions_format_(ead2927)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.02     75.9±2.08ms        ? ?/sec    1.00     74.4±1.85ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00    100.9±1.63ms        ? ?/sec    1.02    102.8±2.80ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.02    120.0±1.97ms        ? ?/sec    1.00    117.5±1.97ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.01     83.6±1.98ms        ? ?/sec    1.00     82.7±1.35ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    128.0±1.56ms        ? ?/sec    1.00    127.9±2.10ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    233.3±4.95ms        ? ?/sec    1.00    233.0±6.89ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    274.1±6.38ms        ? ?/sec    1.00    274.0±5.29ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    141.8±2.08ms        ? ?/sec    1.01    143.8±3.74ms        ? ?/sec
bundle/bundle@threejs                                               1.06     39.5±2.34ms        ? ?/sec    1.00     37.4±1.04ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     96.3±1.70ms        ? ?/sec    1.01     97.4±1.42ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.04    113.5±1.77ms        ? ?/sec    1.00    109.4±1.46ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     48.8±0.67ms        ? ?/sec    1.02     50.0±1.43ms        ? ?/sec
bundle/bundle@threejs10x                                            1.01    406.2±4.98ms        ? ?/sec    1.00    404.1±4.65ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.01  1273.4±16.95ms        ? ?/sec    1.00  1257.9±10.87ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.01  1483.1±15.04ms        ? ?/sec    1.00  1474.1±12.95ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.02    487.8±6.27ms        ? ?/sec    1.00    478.6±6.16ms        ? ?/sec
remapping/remapping                                                 1.00     28.7±0.16ms        ? ?/sec    1.01     28.9±0.25ms        ? ?/sec
remapping/render-chunk-remapping                                    1.01     76.7±0.38ms        ? ?/sec    1.00     76.3±0.38ms        ? ?/sec
scan/scan@rome-ts                                                   1.00    102.9±2.03ms        ? ?/sec    1.01    103.7±2.36ms        ? ?/sec
scan/scan@threejs                                                   1.02     29.3±0.97ms        ? ?/sec    1.00     28.8±0.64ms        ? ?/sec
scan/scan@threejs10x                                                1.01    296.3±3.82ms        ? ?/sec    1.00    294.7±4.30ms        ? ?/sec

@hyf0 hyf0 force-pushed the 11-24-feat_rust_pass_normalizedoutputoptions_from_rust_to_js branch from cf0644c to 22e01b9 Compare November 24, 2024 13:24
@hyf0 hyf0 force-pushed the 11-24-feat_node_rollup-compat_be_compatable_with_rollup_s_normalizedoutputoptions_format_ branch from 9794f7a to 5ebdca9 Compare November 24, 2024 13:24
@hyf0 hyf0 mentioned this pull request Nov 24, 2024
Merged
@hyf0 hyf0 force-pushed the 11-24-feat_rust_pass_normalizedoutputoptions_from_rust_to_js branch from 22e01b9 to c060a8d Compare November 24, 2024 14:14
Base automatically changed from 11-24-feat_rust_pass_normalizedoutputoptions_from_rust_to_js to main November 24, 2024 14:50
@hyf0 hyf0 force-pushed the 11-24-feat_node_rollup-compat_be_compatable_with_rollup_s_normalizedoutputoptions_format_ branch from 5ebdca9 to ead2927 Compare November 24, 2024 14:52
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 24, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit ead2927
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/67433da3d1172d00082ee66c

@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Nov 24, 2024

Merge activity

  • Nov 24, 9:52 AM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@hyf0 hyf0 added this pull request to the merge queue Nov 24, 2024
Merged via the queue into main with commit b5df408 Nov 24, 2024
@hyf0 hyf0 deleted the 11-24-feat_node_rollup-compat_be_compatable_with_rollup_s_normalizedoutputoptions_format_ branch November 24, 2024 15:24
This was referenced Nov 24, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: the type of NormalizedOutputOptions.format is not compatible with rollup

2 participants

@hyf0 @IWANABETHATGUY