Skip to content

chore(rust): rename BindingNormalizedInputOptions to BindingNormalizedOptions#2897

Merged
hyf0 merged 1 commit intomainfrom
11-24-chore_rust_rename_bindingnormalizedinputoptions_to_bindingnormalizedoptions_
Nov 24, 2024
Merged

chore(rust): rename BindingNormalizedInputOptions to BindingNormalizedOptions#2897
hyf0 merged 1 commit intomainfrom
11-24-chore_rust_rename_bindingnormalizedinputoptions_to_bindingnormalizedoptions_

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Nov 24, 2024 •
edited
Loading

Description

Part of #1041. No need to add an extra BindingNormalizedOutputOptions, we could just reuse the current one.

@hyf0 hyf0 marked this pull request as ready for review November 24, 2024 12:39
@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Nov 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Nov 24, 2024
Merged
Merged
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 24, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit fec38e4
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/67431e772fff000008bee47e

@hyf0 hyf0 mentioned this pull request Nov 24, 2024
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 24, 2024

Benchmarks Rust

  • target: main(5150802)
  • pr: 11-24-chore_rust_rename_bindingnormalizedinputoptions_to_bindingnormalizedoptions_(fec38e4)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     74.4±1.29ms        ? ?/sec    1.01     75.3±3.04ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00    100.8±1.64ms        ? ?/sec    1.00    100.9±1.30ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    115.3±1.01ms        ? ?/sec    1.00    115.4±1.51ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     83.4±1.52ms        ? ?/sec    1.00     83.4±1.24ms        ? ?/sec
bundle/bundle@rome-ts                                               1.02    131.5±2.88ms        ? ?/sec    1.00    129.3±2.58ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    229.5±3.18ms        ? ?/sec    1.02    234.5±4.68ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    268.4±4.32ms        ? ?/sec    1.01    270.5±2.89ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    142.8±2.81ms        ? ?/sec    1.00    143.1±1.39ms        ? ?/sec
bundle/bundle@threejs                                               1.02     38.6±3.16ms        ? ?/sec    1.00     37.7±0.89ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.02     97.2±3.22ms        ? ?/sec    1.00     95.5±0.74ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    108.2±1.49ms        ? ?/sec    1.05    113.3±0.66ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     48.2±0.51ms        ? ?/sec    1.01     48.7±0.97ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    407.1±7.76ms        ? ?/sec    1.00    408.5±4.08ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1264.4±4.95ms        ? ?/sec    1.00  1265.3±10.43ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1471.4±10.51ms        ? ?/sec    1.01  1481.8±11.42ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    483.3±4.01ms        ? ?/sec    1.00    481.3±4.07ms        ? ?/sec
remapping/remapping                                                 1.01     28.4±0.27ms        ? ?/sec    1.00     28.1±0.13ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     75.6±0.41ms        ? ?/sec    1.01     76.5±0.42ms        ? ?/sec
scan/scan@rome-ts                                                   1.00    102.9±1.64ms        ? ?/sec    1.02    104.9±0.99ms        ? ?/sec
scan/scan@threejs                                                   1.00     28.9±1.12ms        ? ?/sec    1.00     28.8±0.46ms        ? ?/sec
scan/scan@threejs10x                                                1.00    291.9±3.48ms        ? ?/sec    1.01    295.3±2.24ms        ? ?/sec

@hyf0 hyf0 mentioned this pull request Nov 24, 2024
Merged
@hyf0 hyf0 mentioned this pull request Nov 24, 2024
Merged
@hyf0 hyf0 added this pull request to the merge queue Nov 24, 2024
Merged via the queue into main with commit 01d1e62 Nov 24, 2024
@hyf0 hyf0 deleted the 11-24-chore_rust_rename_bindingnormalizedinputoptions_to_bindingnormalizedoptions_ branch November 24, 2024 13:50
@hyf0 hyf0 mentioned this pull request Nov 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @IWANABETHATGUY