Skip to content

refactor(rust): add HookGenerateBundleArgs#2901

Merged
hyf0 merged 5 commits intomainfrom
11-24-refactor_rust_add_hookgeneratebundleargs_
Nov 24, 2024
Merged

refactor(rust): add HookGenerateBundleArgs#2901
hyf0 merged 5 commits intomainfrom
11-24-refactor_rust_add_hookgeneratebundleargs_

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Nov 24, 2024 •
edited
Loading

Description

This make it easier to add more args.

@hyf0 hyf0 mentioned this pull request Nov 24, 2024
Merged
@hyf0 hyf0 marked this pull request as ready for review November 24, 2024 13:04
This was referenced Nov 24, 2024
Merged
Merged
@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Nov 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 mentioned this pull request Nov 24, 2024
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 24, 2024 •
edited
Loading

Benchmarks Rust

  • target: 11-24-feat_node_rollup-compat_be_compatable_with_rollup_s_normalizedoutputoptions_format_(5ebdca9)
  • pr: 11-24-refactor_rust_add_hookgeneratebundleargs_(7396534)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     82.7±2.17ms        ? ?/sec    1.05     86.8±2.40ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.01    109.0±1.94ms        ? ?/sec    1.00    108.0±2.39ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.03    126.5±2.79ms        ? ?/sec    1.00    122.9±2.64ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     90.6±2.15ms        ? ?/sec    1.00     90.5±2.07ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    135.0±2.64ms        ? ?/sec    1.05    142.1±3.92ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    259.1±4.92ms        ? ?/sec    1.08   281.0±14.88ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00   295.1±13.28ms        ? ?/sec    1.07   316.0±21.44ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    149.0±1.27ms        ? ?/sec    1.03    153.1±1.64ms        ? ?/sec
bundle/bundle@threejs                                               1.01     39.9±1.51ms        ? ?/sec    1.00     39.6±1.01ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.01    102.6±1.68ms        ? ?/sec    1.00    102.0±1.31ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    119.3±0.99ms        ? ?/sec    1.01    120.1±1.80ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     51.0±0.75ms        ? ?/sec    1.00     51.1±0.78ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    424.7±4.52ms        ? ?/sec    1.00    425.3±4.50ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1334.7±9.10ms        ? ?/sec    1.00   1328.7±9.61ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1555.9±15.69ms        ? ?/sec    1.00  1553.6±12.53ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    499.1±5.53ms        ? ?/sec    1.01    502.3±5.13ms        ? ?/sec
remapping/remapping                                                 1.03     29.3±0.69ms        ? ?/sec    1.00     28.5±0.17ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     77.3±0.42ms        ? ?/sec    1.03     79.2±1.76ms        ? ?/sec
scan/scan@rome-ts                                                   1.01    105.9±1.46ms        ? ?/sec    1.00    105.3±1.34ms        ? ?/sec
scan/scan@threejs                                                   1.00     30.2±1.12ms        ? ?/sec    1.00     30.1±0.99ms        ? ?/sec
scan/scan@threejs10x                                                1.00    303.0±4.39ms        ? ?/sec    1.00    302.7±3.18ms        ? ?/sec

@hyf0 hyf0 force-pushed the 11-24-feat_node_rollup-compat_be_compatable_with_rollup_s_normalizedoutputoptions_format_ branch from 9794f7a to 5ebdca9 Compare November 24, 2024 13:24
@hyf0 hyf0 force-pushed the 11-24-refactor_rust_add_hookgeneratebundleargs_ branch from bd57575 to 7396534 Compare November 24, 2024 13:24
@hyf0 hyf0 mentioned this pull request Nov 24, 2024
Merged
@hyf0 hyf0 force-pushed the 11-24-feat_node_rollup-compat_be_compatable_with_rollup_s_normalizedoutputoptions_format_ branch from 5ebdca9 to ead2927 Compare November 24, 2024 14:52
Base automatically changed from 11-24-feat_node_rollup-compat_be_compatable_with_rollup_s_normalizedoutputoptions_format_ to main November 24, 2024 15:24
@hyf0 hyf0 added this pull request to the merge queue Nov 24, 2024
Merged via the queue into main with commit 788d7fc Nov 24, 2024
@hyf0 hyf0 deleted the 11-24-refactor_rust_add_hookgeneratebundleargs_ branch November 24, 2024 15:41
@hyf0 hyf0 mentioned this pull request Nov 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @IWANABETHATGUY