Skip to content

feat(rust): pass NormalizedOutputOptions from rust to js#2899

Merged
hyf0 merged 1 commit intomainfrom
11-24-feat_rust_pass_normalizedoutputoptions_from_rust_to_js
Nov 24, 2024
Merged

feat(rust): pass NormalizedOutputOptions from rust to js#2899
hyf0 merged 1 commit intomainfrom
11-24-feat_rust_pass_normalizedoutputoptions_from_rust_to_js

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Nov 24, 2024 •
edited
Loading

Description

Part of #1041.

@hyf0 hyf0 mentioned this pull request Nov 24, 2024
Merged
@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Nov 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 mentioned this pull request Nov 24, 2024
Merged
@hyf0 hyf0 marked this pull request as ready for review November 24, 2024 12:39
@hyf0 hyf0 mentioned this pull request Nov 24, 2024
Merged
@hyf0 hyf0 force-pushed the 11-24-feat_rust_pass_normalizedoutputoptions_from_rust_to_js branch from 5b75747 to 15fc31a Compare November 24, 2024 12:52
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 24, 2024 •
edited
Loading

Benchmarks Rust

  • target: main(9755e1b)
  • pr: 11-24-feat_rust_pass_normalizedoutputoptions_from_rust_to_js(c060a8d)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     74.9±2.35ms        ? ?/sec    1.12     84.1±1.97ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00    102.0±1.82ms        ? ?/sec    1.00    101.7±1.52ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    116.2±1.52ms        ? ?/sec    1.00    116.6±1.73ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     83.5±1.38ms        ? ?/sec    1.06     88.2±2.30ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    127.5±1.82ms        ? ?/sec    1.07    136.4±1.53ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    227.8±2.12ms        ? ?/sec    1.19    270.2±8.33ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    265.8±3.57ms        ? ?/sec    1.18    313.5±9.46ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    140.8±1.32ms        ? ?/sec    1.06    149.8±2.17ms        ? ?/sec
bundle/bundle@threejs                                               1.00     38.5±3.70ms        ? ?/sec    1.00     38.5±0.73ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     98.6±3.84ms        ? ?/sec    1.02    100.4±3.85ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    114.4±3.22ms        ? ?/sec    1.10    125.4±1.93ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     48.4±1.19ms        ? ?/sec    1.02     49.5±0.65ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    409.5±3.32ms        ? ?/sec    1.05    428.8±4.45ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00  1265.0±10.59ms        ? ?/sec    1.05   1330.6±8.51ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1485.7±11.66ms        ? ?/sec    1.04   1544.0±8.53ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    488.3±7.19ms        ? ?/sec    1.03    501.7±5.32ms        ? ?/sec
remapping/remapping                                                 1.00     28.1±0.20ms        ? ?/sec    1.01     28.3±0.13ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     76.6±0.33ms        ? ?/sec    1.00     76.9±0.52ms        ? ?/sec
scan/scan@rome-ts                                                   1.00    103.6±1.79ms        ? ?/sec    1.00    103.8±3.70ms        ? ?/sec
scan/scan@threejs                                                   1.00     28.7±0.92ms        ? ?/sec    1.02     29.2±0.34ms        ? ?/sec
scan/scan@threejs10x                                                1.00    293.5±4.10ms        ? ?/sec    1.01    297.5±2.71ms        ? ?/sec

@hyf0 hyf0 force-pushed the 11-24-refactor_node_use_raw_outputoptions_in_bindingifyoutputoptions_ branch from 1595692 to d645d01 Compare November 24, 2024 13:04
@hyf0 hyf0 force-pushed the 11-24-feat_rust_pass_normalizedoutputoptions_from_rust_to_js branch from 15fc31a to cf0644c Compare November 24, 2024 13:04
@hyf0 hyf0 mentioned this pull request Nov 24, 2024
Merged
@hyf0 hyf0 force-pushed the 11-24-feat_rust_pass_normalizedoutputoptions_from_rust_to_js branch from cf0644c to 22e01b9 Compare November 24, 2024 13:24
@hyf0 hyf0 mentioned this pull request Nov 24, 2024
Merged
@hyf0
Copy link
Copy Markdown
Member Author

hyf0 commented Nov 24, 2024

This should also solves #2885, but need to a test to check.

Base automatically changed from 11-24-refactor_node_use_raw_outputoptions_in_bindingifyoutputoptions_ to main November 24, 2024 14:13
@hyf0 hyf0 force-pushed the 11-24-feat_rust_pass_normalizedoutputoptions_from_rust_to_js branch from 22e01b9 to c060a8d Compare November 24, 2024 14:14
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 24, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit c060a8d
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/674334a94dae80000871e37f

@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Nov 24, 2024

Merge activity

  • Nov 24, 9:14 AM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@hyf0 hyf0 added this pull request to the merge queue Nov 24, 2024
Merged via the queue into main with commit ac28e50 Nov 24, 2024
@hyf0 hyf0 deleted the 11-24-feat_rust_pass_normalizedoutputoptions_from_rust_to_js branch November 24, 2024 14:50
This was referenced Nov 24, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @IWANABETHATGUY