Skip to content

refactor(node): use raw OutputOptions in bindingifyOutputOptions#2898

Merged
hyf0 merged 2 commits intomainfrom
11-24-refactor_node_use_raw_outputoptions_in_bindingifyoutputoptions_
Nov 24, 2024
Merged

refactor(node): use raw OutputOptions in bindingifyOutputOptions#2898
hyf0 merged 2 commits intomainfrom
11-24-refactor_node_use_raw_outputoptions_in_bindingifyoutputoptions_

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Nov 24, 2024

Description

Part of #1041. There's no NormalizedOutputOptions. We pass raw options to rust directly not normalized.

@hyf0 hyf0 marked this pull request as ready for review November 24, 2024 12:39
@hyf0 hyf0 force-pushed the 11-24-refactor_node_use_raw_outputoptions_in_bindingifyoutputoptions_ branch from 1595692 to d645d01 Compare November 24, 2024 13:04
Base automatically changed from 11-24-chore_rust_rename_bindingnormalizedinputoptions_to_bindingnormalizedoptions_ to main November 24, 2024 13:50
@hyf0 hyf0 added this pull request to the merge queue Nov 24, 2024
Merged via the queue into main with commit 9755e1b Nov 24, 2024
@hyf0 hyf0 deleted the 11-24-refactor_node_use_raw_outputoptions_in_bindingifyoutputoptions_ branch November 24, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants