[ci] remove TD + test specification code from run_test.py#79372
Closed
suo wants to merge 3 commits intogh/suo/561/basefrom
Closed
[ci] remove TD + test specification code from run_test.py#79372suo wants to merge 3 commits intogh/suo/561/basefrom
suo wants to merge 3 commits intogh/suo/561/basefrom
Conversation
This was referenced Jun 12, 2022
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit fcae440 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jun 12, 2022
[ghstack-poisoned]
In the case of target determination, this is just removing comments that refer to non-existent code. In the case of the test specification code; this removes (what I believe to be) an unused feature. If we're using this somehow let me know and I can revise the PR. [ghstack-poisoned]
janeyx99
approved these changes
Jun 13, 2022
| return slow_tests | ||
|
|
||
|
|
||
| def get_specified_test_cases(filename: str, tests: List[str]) -> Dict[str, List[str]]: |
Contributor
There was a problem hiding this comment.
hahahaha bye bye smoke tests infra
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 14, 2022
Summary: In the case of target determination, this is just removing comments that refer to non-existent code. In the case of the test specification code; this removes (what I believe to be) an unused feature. If we're using this somehow let me know and I can revise the PR. Pull Request resolved: #79372 Approved by: https://github.com/janeyx99 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/842da8a5decb5bd609dcbbc5ab775d2ee9ab48b8 Reviewed By: osalpekar Differential Revision: D37119146 Pulled By: suo fbshipit-source-id: fcf45c70711a29f21991a3ea089acba9e286270f
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
In the case of target determination, this is just removing comments that refer to non-existent code. In the case of the test specification code; this removes (what I believe to be) an unused feature. If we're using this somehow let me know and I can revise the PR. Pull Request resolved: pytorch#79372 Approved by: https://github.com/janeyx99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
CUSTOM_TEST_ARTIFACT_BUILD_DIR#79362In the case of target determination, this is just removing comments that
refer to non-existent code.
In the case of the test specification code; this removes (what I believe
to be) an unused feature. If we're using this somehow let me know and I
can revise the PR.