Skip to content

[ci] convert empty s3 artifacts from error to warning#79397

Closed
suo wants to merge 2 commits intogh/suo/565/basefrom
gh/suo/565/head
Closed

[ci] convert empty s3 artifacts from error to warning#79397
suo wants to merge 2 commits intogh/suo/565/basefrom
gh/suo/565/head

Conversation

@suo
Copy link
Copy Markdown
Member

@suo suo commented Jun 13, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

There are a bunch of valid reasons this could happen (e.g. all builds
failed before running any tests), so it shouldn't cause the workflow to
error. Should probably still warn though if we ever are investigating.

@suo
[ci] convert empty s3 artifacts from error to warning
31c2fc8 
There are a bunch of valid reasons this could happen (e.g. all builds
failed before running any tests), so it shouldn't cause the workflow to
error. Should probably still warn though if we ever are investigating.

[ghstack-poisoned]
This was referenced Jun 13, 2022
Closed
Closed
This was referenced Jun 13, 2022
Closed
Closed
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 13, 2022 •
edited
Loading

🔗 Helpful links

❌ 1 New Failures

As of commit 27a6915 (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-focal-py3.7-gcc7 / test (backwards_compat, 1, 1, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-06-15T17:18:28.3012605Z RuntimeError: 
2022-06-15T17:18:27.5998062Z Author: PyTorch Team
2022-06-15T17:18:27.5998498Z Author-email: packages@pytorch.org
2022-06-15T17:18:27.5998916Z License: BSD-3
2022-06-15T17:18:27.5999247Z Location: /opt/conda/lib/python3.7/site-packages
2022-06-15T17:18:27.5999528Z Requires: typing-extensions
2022-06-15T17:18:27.5999751Z Required-by: 
2022-06-15T17:18:27.6417387Z + python check_forward_backward_compatibility.py --existing-schemas nightly_schemas.txt
2022-06-15T17:18:28.3011699Z Traceback (most recent call last):
2022-06-15T17:18:28.3012068Z   File "check_forward_backward_compatibility.py", line 345, in <module>
2022-06-15T17:18:28.3012342Z     s = parse_schema(line.strip())
2022-06-15T17:18:28.3012605Z RuntimeError: 
2022-06-15T17:18:28.3012877Z Unknown custom class type c10d.ProcessGroup. Please ensure it is registered.:
2022-06-15T17:18:28.3013575Z c10d::broadcast(__torch__.torch.classes.c10d.ProcessGroup _0, Tensor[] _1, int _2, int _3, int _4) -> __torch__.torch.classes.c10d.Work _0
2022-06-15T17:18:28.3014324Z                                              ~~~~~~~~~~~~ <--- HERE
2022-06-15T17:18:28.3014467Z 
2022-06-15T17:18:28.4281458Z + cleanup
2022-06-15T17:18:28.4281671Z + retcode=1
2022-06-15T17:18:28.4281899Z + set +x
2022-06-15T17:18:28.4317456Z ##[error]Process completed with exit code 1.
2022-06-15T17:18:28.4367030Z Prepare all required actions
2022-06-15T17:18:28.4367278Z Getting action download info
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Jun 13, 2022
Closed
Closed
Closed
Closed
Closed
Closed
suo added a commit that referenced this pull request Jun 13, 2022
@suo
[ci] convert empty s3 artifacts from error to warning
61416e2 
There are a bunch of valid reasons this could happen (e.g. all builds
failed before running any tests), so it shouldn't cause the workflow to
error. Should probably still warn though if we ever are investigating.

ghstack-source-id: 79d46fb
Pull Request resolved: #79397
@suo
Update on "[ci] convert empty s3 artifacts from error to warning"
27a6915 
There are a bunch of valid reasons this could happen (e.g. all builds
failed before running any tests), so it shouldn't cause the workflow to
error. Should probably still warn though if we ever are investigating.

[ghstack-poisoned]
suo added a commit that referenced this pull request Jun 13, 2022
@suo
[ci] convert empty s3 artifacts from error to warning
a6d76e1 
There are a bunch of valid reasons this could happen (e.g. all builds
failed before running any tests), so it shouldn't cause the workflow to
error. Should probably still warn though if we ever are investigating.

ghstack-source-id: d17c7b9
Pull Request resolved: #79397
@suo
Copy link
Copy Markdown
Member Author

suo commented Jun 13, 2022

@pytorchbot merg

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Jun 13, 2022

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'merg' (choose from 'merge', 'revert', 'rebase', 'help')

usage: @pytorchbot {merge,revert,rebase,help} ...

Try @pytorchbot help for more info.

@suo
Copy link
Copy Markdown
Member Author

suo commented Jun 13, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 13, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 13, 2022

Hey @suo.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 15, 2022
@suo @facebook-github-bot
[ci] convert empty s3 artifacts from error to warning (#79397)
fbca25d 
Summary:
There are a bunch of valid reasons this could happen (e.g. all builds
failed before running any tests), so it shouldn't cause the workflow to
error. Should probably still warn though if we ever are investigating.

Pull Request resolved: #79397

Approved by: https://github.com/janeyx99

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/d42d5fe778f6e0dd0a2bd7e96fb00b2894353861

Reviewed By: malfet

Differential Revision: D37153128

Pulled By: suo

fbshipit-source-id: 4cd73b90271ffee1cff828977490c8fbf017a58b
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 15, 2022

@pytorchbot revert -m="Diff reverted internally" -c="ghfirst"

This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).)

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 15, 2022

@pytorchbot successfully started a revert job. Check the current status here

pytorchmergebot added a commit that referenced this pull request Jun 15, 2022
@pytorchmergebot
Revert "[ci] convert empty s3 artifacts from error to warning"
5de9f42 
This reverts commit d42d5fe.

Reverted #79397 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally
@suo suo reopened this Jun 15, 2022
@suo suo closed this Jun 16, 2022
@facebook-github-bot facebook-github-bot deleted the gh/suo/565/head branch June 19, 2022 14:16
@zengk95 zengk95 mentioned this pull request Jun 22, 2022
Closed
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@suo @pytorchmergebot
[ci] convert empty s3 artifacts from error to warning
76164f9 
There are a bunch of valid reasons this could happen (e.g. all builds
failed before running any tests), so it shouldn't cause the workflow to
error. Should probably still warn though if we ever are investigating.

Pull Request resolved: pytorch#79397

Approved by: https://github.com/janeyx99
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@pytorchmergebot
Revert "[ci] convert empty s3 artifacts from error to warning"
c8ee5cd 
This reverts commit 76164f9.

Reverted pytorch#79397 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janeyx99 janeyx99 janeyx99 approved these changes

Assignees

No one assigned

Labels

cla signed Merged Reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@suo @facebook-github-bot @pytorchmergebot @janeyx99