[ci] remove remaining RDS dependency#79370
Closed
suo wants to merge 8 commits intogh/suo/560/basefrom
Closed
Conversation
With #79366, the only remaining use case for RDS is import latency stats. Afaik we do not look at these, so removing, which eliminates our last dependency on RDS. [ghstack-poisoned]
This was referenced Jun 12, 2022
Contributor
🔗 Helpful links
❌ 1 New FailuresAs of commit 4b9dade (more details on the Dr. CI page): Expand to see more
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
This was referenced Jun 12, 2022
With #79366, the only remaining use case for RDS is import latency stats. Afaik we do not look at these, so removing, which eliminates our last dependency on RDS. [ghstack-poisoned]
With #79366, the only remaining use case for RDS is import latency stats. Afaik we do not look at these, so removing, which eliminates our last dependency on RDS. [ghstack-poisoned]
With #79366, the only remaining use case for RDS is import latency stats. Afaik we do not look at these, so removing, which eliminates our last dependency on RDS. [ghstack-poisoned]
With #79366, the only remaining use case for RDS is import latency stats. Afaik we do not look at these, so removing, which eliminates our last dependency on RDS. [ghstack-poisoned]
With #79366, the only remaining use case for RDS is import latency stats. Afaik we do not look at these, so removing, which eliminates our last dependency on RDS. [ghstack-poisoned]
With #79366, the only remaining use case for RDS is import latency stats. Afaik we do not look at these, so removing, which eliminates our last dependency on RDS. [ghstack-poisoned]
janeyx99
reviewed
Jun 13, 2022
| # as a way to track the duration of `import torch` in our ossci-metrics | ||
| # S3 bucket (see tools/stats/print_test_stats.py) | ||
| class TestImportTime(TestCase): | ||
| def test_time_import_torch(self): |
Contributor
There was a problem hiding this comment.
Would it be a good time now to set this to fail if it's over a threshold? Do we...care?
Contributor
There was a problem hiding this comment.
Actually, if we do care about tracking these stats, we can just run these as normal, right? The test_runs in Rockset will keep track of these times already.
Member
Author
There was a problem hiding this comment.
that's a good point! I will re-add
With #79366, the only remaining use case for RDS is import latency stats. Afaik we do not look at these, so removing, which eliminates our last dependency on RDS. [ghstack-poisoned]
janeyx99
approved these changes
Jun 13, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 15, 2022
Summary: With #79366, the only remaining use case for RDS is import latency stats. Afaik we do not look at these, so removing, which eliminates our last dependency on RDS. Pull Request resolved: #79370 Approved by: https://github.com/janeyx99 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/964d5059587c017b02f1d7d62587722a38683c63 Reviewed By: malfet Differential Revision: D37153120 Pulled By: suo fbshipit-source-id: 6a2e1fb827a88e0828b1f05fdbe62f07ec61da87
Contributor
|
@pytorchbot revert -m="Diff reverted internally" -c="ghfirst" This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).) |
Collaborator
|
@pytorchbot successfully started a revert job. Check the current status here |
pytorchmergebot
added a commit
that referenced
this pull request
Jun 15, 2022
This reverts commit 964d505. Reverted #79370 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
With pytorch#79366, the only remaining use case for RDS is import latency stats. Afaik we do not look at these, so removing, which eliminates our last dependency on RDS. Pull Request resolved: pytorch#79370 Approved by: https://github.com/janeyx99
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
This reverts commit 5d70521. Reverted pytorch#79370 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
With #79366, the only remaining
use case for RDS is import latency stats. Afaik we do not look at these,
so removing, which eliminates our last dependency on RDS.