[ci] improvements to test stats uploading#79364
Closed
suo wants to merge 2 commits intogh/suo/555/basefrom
Closed
Conversation
Two improvements that are useful for `testsuite` uploading: - When there are multiple tags of the same name, coalesce them into a list. This allows us to capture, e.g. when a `testsuite` contains multiple `testcase`s. - Be able to skip a tag. We don't really want the inner `testcase` tags, since we upload those separately. [ghstack-poisoned]
This was referenced Jun 12, 2022
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit d1065ba (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jun 12, 2022
Two improvements that are useful for `testsuite` uploading: - When there are multiple tags of the same name, coalesce them into a list. This allows us to capture, e.g. when a `testsuite` contains multiple `testcase`s. - Be able to skip a tag. We don't really want the inner `testcase` tags, since we upload those separately. [ghstack-poisoned]
janeyx99
approved these changes
Jun 13, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 14, 2022
Summary: Two improvements that are useful for `testsuite` uploading: - When there are multiple tags of the same name, coalesce them into a list. This allows us to capture, e.g. when a `testsuite` contains multiple `testcase`s. - Be able to skip a tag. We don't really want the inner `testcase` tags, since we upload those separately. Pull Request resolved: #79364 Approved by: https://github.com/janeyx99 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/03a1bb61fcaaede66749c5b25aa7eb05484be9d1 Reviewed By: osalpekar Differential Revision: D37119143 Pulled By: suo fbshipit-source-id: 61604e19d8ee44d161e0f21fb6517a4165337066
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
Two improvements that are useful for `testsuite` uploading: - When there are multiple tags of the same name, coalesce them into a list. This allows us to capture, e.g. when a `testsuite` contains multiple `testcase`s. - Be able to skip a tag. We don't really want the inner `testcase` tags, since we upload those separately. Pull Request resolved: pytorch#79364 Approved by: https://github.com/janeyx99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
CUSTOM_TEST_ARTIFACT_BUILD_DIR#79362Two improvements that are useful for
testsuiteuploading:list. This allows us to capture, e.g. when a
testsuitecontainsmultiple
testcases.testcasetags,since we upload those separately.