[ci] clean up dead code related to PR test selection#79363
Closed
suo wants to merge 2 commits intogh/suo/554/basefrom
Closed
[ci] clean up dead code related to PR test selection#79363suo wants to merge 2 commits intogh/suo/554/basefrom
suo wants to merge 2 commits intogh/suo/554/basefrom
Conversation
This is never used and not tested, so removing it for clarity. [ghstack-poisoned]
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 1cf0ebb (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jun 12, 2022
This is never used and not tested, so removing it for clarity. [ghstack-poisoned]
janeyx99
reviewed
Jun 13, 2022
|
|
||
| def get_reordered_tests(tests: List[str], is_reordering_by_pr: bool) -> List[str]: | ||
| def get_reordered_tests(tests: List[str]) -> List[str]: | ||
| """Get the reordered test filename list based on github PR history or git changed file.""" |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| """Get the reordered test filename list based on github PR history or git changed file.""" | |
| """Get the reordered test filename list based on git changed files.""" |
janeyx99
approved these changes
Jun 13, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 14, 2022
Summary: This is never used and not tested, so removing it for clarity. Pull Request resolved: #79363 Approved by: https://github.com/janeyx99 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/943c09a53e70a720c80e6a53948a95a00e4715a0 Reviewed By: osalpekar Differential Revision: D37119144 Pulled By: suo fbshipit-source-id: 9cdff2ba9881428210835f0582c6b1b7a248c80b
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
This is never used and not tested, so removing it for clarity. Pull Request resolved: pytorch#79363 Approved by: https://github.com/janeyx99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
CUSTOM_TEST_ARTIFACT_BUILD_DIR#79362This is never used and not tested, so removing it for clarity.