[ci] minor refactorings to common ci scripts#79294
Closed
suo wants to merge 6 commits intogh/suo/551/basefrom
Closed
[ci] minor refactorings to common ci scripts#79294suo wants to merge 6 commits intogh/suo/551/basefrom
suo wants to merge 6 commits intogh/suo/551/basefrom
Conversation
1. Move utility functions from `common.sh` to `common_utils.sh`. 2. Make common_utils.sh *only* declare functions, no other side effects. [ghstack-poisoned]
This was referenced Jun 10, 2022
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 13a311a (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
1. Move utility functions from `common.sh` to `common_utils.sh`. 2. Make common_utils.sh *only* declare functions, no other side effects. [ghstack-poisoned]
1. Move utility functions from `common.sh` to `common_utils.sh`. 2. Make common_utils.sh *only* declare functions, no other side effects. [ghstack-poisoned]
1. Move utility functions from `common.sh` to `common_utils.sh`. 2. Make common_utils.sh *only* declare functions, no other side effects. [ghstack-poisoned]
1. Move utility functions from `common.sh` to `common_utils.sh`. 2. Make common_utils.sh *only* declare functions, no other side effects. [ghstack-poisoned]
1. Move utility functions from `common.sh` to `common_utils.sh`. 2. Make common_utils.sh *only* declare functions, no other side effects. [ghstack-poisoned]
janeyx99
approved these changes
Jun 13, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 14, 2022
Summary: 1. Move utility functions from `common.sh` to `common_utils.sh`. 2. Make common_utils.sh *only* declare functions, no other side effects. Pull Request resolved: #79294 Approved by: https://github.com/janeyx99 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/91659dea83e2a272de5ebb6353236e029d918b1a Reviewed By: osalpekar Differential Revision: D37119142 Pulled By: suo fbshipit-source-id: d93722b73abd38fe946155ff927ed595708b5b02
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
1. Move utility functions from `common.sh` to `common_utils.sh`. 2. Make common_utils.sh *only* declare functions, no other side effects. Pull Request resolved: pytorch#79294 Approved by: https://github.com/janeyx99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
CUSTOM_TEST_ARTIFACT_BUILD_DIR#79362common.shtocommon_utils.sh.