stop creating jit/generated/ directory by dagitses · Pull Request #74836 · pytorch/pytorch

dagitses · 2022-03-28T16:53:04Z

Stack from ghstack (oldest at bottom):

I don't believe this is used any more.

Differential Revision: D35187900

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

facebook-github-bot · 2022-03-28T16:53:11Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/74836
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

💊 CI failures summary and remediations

As of commit 53508eb (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

facebook-github-bot · 2022-04-17T20:53:27Z

@pytorchbot merge this

(Initiating merge automatically since Phabricator Diff has merged)

github-actions · 2022-04-17T20:55:08Z

Hey @dagitses.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: Pull Request resolved: #74836 I don't believe this is used any more. ghstack-source-id: 154076247 Test Plan: Rely on CI to validate. Reviewed By: ezyang, malfet Differential Revision: D35187900 fbshipit-source-id: c0de9776947eb3090d68e3952308f028800d7133

Pull Request resolved: #74836 I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) Approved by: https://github.com/albanD, https://github.com/malfet (cherry picked from commit 92a5815)

Pull Request resolved: pytorch#74836 I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) Approved by: https://github.com/albanD, https://github.com/malfet

stop creating jit/generated/ directory

4497a52

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

facebook-github-bot added the cla signed label Mar 28, 2022

Michael Andreas Dagitses added 2 commits March 28, 2022 09:59

Update on "stop creating jit/generated/ directory"

bf97584

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

9faa9bf

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

dagitses mentioned this pull request Mar 28, 2022

move setup_helpers programs to shared build structure #74849

Closed

Michael Andreas Dagitses added 13 commits March 28, 2022 12:16

Update on "stop creating jit/generated/ directory"

752ca6d

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

bbaae49

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

28f599e

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

afa3987

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

8e93c4f

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

9144f5e

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

727f152

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

639174f

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

c1e99c9

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

e07c392

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

d4a6589

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

e26133d

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

f5c1ab7

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Michael Andreas Dagitses added 2 commits April 14, 2022 03:40

Update on "stop creating jit/generated/ directory"

e2d9fa8

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

912b4fa

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

dagitses mentioned this pull request Apr 14, 2022

switch Bazel to the shared generate-code genrule #75790

Closed

Update on "stop creating jit/generated/ directory"

aa96a20

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

dagitses mentioned this pull request Apr 14, 2022

introduce new --gen-dir flag to generate_code and use it in fbcode #75800

Closed

malfet approved these changes Apr 14, 2022

View reviewed changes

malfet reviewed Apr 14, 2022

View reviewed changes

Comment thread tools/setup_helpers/generate_code.py Outdated

Update on "stop creating jit/generated/ directory"

d5f3fac

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

This was referenced Apr 15, 2022

use pathlib.Path for --install_dir and downstream variables #75867

Closed

remove unused all_generator_source from generate_code #75868

Closed

remove unused --ninja-global from codegen #75869

Closed

Michael Andreas Dagitses added 6 commits April 15, 2022 15:51

Update on "stop creating jit/generated/ directory"

9242ec2

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

b1d23c7

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

36811cb

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

40c96a5

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

586c948

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

eb60276

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

dagitses mentioned this pull request Apr 16, 2022

define and disable the caffe2_serialize target in Bazel #75942

Closed

Michael Andreas Dagitses added 4 commits April 16, 2022 14:03

Update on "stop creating jit/generated/ directory"

cd32a01

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

af8c6b9

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

438c409

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

Update on "stop creating jit/generated/ directory"

53508eb

I don't believe this is used any more. Differential Revision: [D35187900](https://our.internmc.facebook.com/intern/diff/D35187900/) [ghstack-poisoned]

pytorchmergebot closed this in 92a5815 Apr 17, 2022

facebook-github-bot deleted the gh/dagitses/302/head branch April 21, 2022 14:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

stop creating jit/generated/ directory#74836

stop creating jit/generated/ directory#74836
dagitses wants to merge 66 commits into
gh/dagitses/302/basefrom
gh/dagitses/302/head

dagitses commented Mar 28, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented Mar 28, 2022 •

edited

Loading

Uh oh!

Uh oh!

facebook-github-bot commented Apr 17, 2022

Uh oh!

github-actions Bot commented Apr 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dagitses commented Mar 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Mar 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

Uh oh!

Uh oh!

facebook-github-bot commented Apr 17, 2022

Uh oh!

github-actions Bot commented Apr 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dagitses commented Mar 28, 2022 •

edited

Loading

facebook-github-bot commented Mar 28, 2022 •

edited

Loading