Make Dispatcher::backendFallbackKernels_ an array#30340
Closed
smessmer wants to merge 2 commits intogh/smessmer/122/basefrom
Closed
Make Dispatcher::backendFallbackKernels_ an array#30340smessmer wants to merge 2 commits intogh/smessmer/122/basefrom
smessmer wants to merge 2 commits intogh/smessmer/122/basefrom
Conversation
We already made OperatorEntry::dispatchTable_ an array to be able to avoid the concurrency primitives there, but Dispatcher::backendFallbackKernels_ has the same issue. Let's make it a table too. Since there is some code duplication here, we also factor out the concept of a KernelFunctionTable to be used in both places. Differential Revision: [D18663426](https://our.internmc.facebook.com/intern/diff/D18663426/) [ghstack-poisoned]
This was referenced Nov 22, 2019
smessmer
added a commit
that referenced
this pull request
Nov 22, 2019
We already made OperatorEntry::dispatchTable_ an array to be able to avoid the concurrency primitives there, but Dispatcher::backendFallbackKernels_ has the same issue. Let's make it a table too. Since there is some code duplication here, we also factor out the concept of a KernelFunctionTable to be used in both places. Differential Revision: [D18663426](https://our.internmc.facebook.com/intern/diff/D18663426/) ghstack-source-id: 94449179 Pull Request resolved: #30340
resistor
approved these changes
Nov 22, 2019
This was referenced Nov 22, 2019
Closed
Closed
We already made OperatorEntry::dispatchTable_ an array to be able to avoid the concurrency primitives there, but Dispatcher::backendFallbackKernels_ has the same issue. Let's make it a table too. Since there is some code duplication here, we also factor out the concept of a KernelFunctionTable to be used in both places. Differential Revision: [D18663426](https://our.internmc.facebook.com/intern/diff/D18663426/) [ghstack-poisoned]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We already made OperatorEntry::dispatchTable_ an array to be able to avoid the concurrency primitives there,
but Dispatcher::backendFallbackKernels_ has the same issue. Let's make it a table too.
Since there is some code duplication here, we also factor out the concept of a KernelFunctionTable to be used in both places.
Differential Revision: D18663426