OperatorHandle::callBoxed/callUnboxed#29330
Closed
smessmer wants to merge 13 commits intogh/smessmer/113/basefrom
Closed
OperatorHandle::callBoxed/callUnboxed#29330smessmer wants to merge 13 commits intogh/smessmer/113/basefrom
smessmer wants to merge 13 commits intogh/smessmer/113/basefrom
Conversation
This makes for a nicer API, especially in backend fallback kernels who get an OperatorHandle instance and can directly call these methods on it. Differential Revision: [D18357424](https://our.internmc.facebook.com/intern/diff/D18357424/) [ghstack-poisoned]
This was referenced Nov 6, 2019
smessmer
added a commit
that referenced
this pull request
Nov 6, 2019
This makes for a nicer API, especially in backend fallback kernels who get an OperatorHandle instance and can directly call these methods on it. Differential Revision: [D18357424](https://our.internmc.facebook.com/intern/diff/D18357424/) ghstack-source-id: 93393573 Pull Request resolved: #29330
This makes for a nicer API, especially in backend fallback kernels who get an OperatorHandle instance and can directly call these methods on it. Differential Revision: [D18357424](https://our.internmc.facebook.com/intern/diff/D18357424/) [ghstack-poisoned]
This makes for a nicer API, especially in backend fallback kernels who get an OperatorHandle instance and can directly call these methods on it. Differential Revision: [D18357424](https://our.internmc.facebook.com/intern/diff/D18357424/) [ghstack-poisoned]
This makes for a nicer API, especially in backend fallback kernels who get an OperatorHandle instance and can directly call these methods on it. Differential Revision: [D18357424](https://our.internmc.facebook.com/intern/diff/D18357424/) [ghstack-poisoned]
This makes for a nicer API, especially in backend fallback kernels who get an OperatorHandle instance and can directly call these methods on it. Differential Revision: [D18357424](https://our.internmc.facebook.com/intern/diff/D18357424/) [ghstack-poisoned]
This makes for a nicer API, especially in backend fallback kernels who get an OperatorHandle instance and can directly call these methods on it. Differential Revision: [D18357424](https://our.internmc.facebook.com/intern/diff/D18357424/) [ghstack-poisoned]
This makes for a nicer API, especially in backend fallback kernels who get an OperatorHandle instance and can directly call these methods on it. Differential Revision: [D18357424](https://our.internmc.facebook.com/intern/diff/D18357424/) [ghstack-poisoned]
This makes for a nicer API, especially in backend fallback kernels who get an OperatorHandle instance and can directly call these methods on it. Differential Revision: [D18357424](https://our.internmc.facebook.com/intern/diff/D18357424/) [ghstack-poisoned]
This makes for a nicer API, especially in backend fallback kernels who get an OperatorHandle instance and can directly call these methods on it. Differential Revision: [D18357424](https://our.internmc.facebook.com/intern/diff/D18357424/) [ghstack-poisoned]
ezyang
approved these changes
Nov 15, 2019
This makes for a nicer API, especially in backend fallback kernels who get an OperatorHandle instance and can directly call these methods on it. Differential Revision: [D18357424](https://our.internmc.facebook.com/intern/diff/D18357424/) [ghstack-poisoned]
This makes for a nicer API, especially in backend fallback kernels who get an OperatorHandle instance and can directly call these methods on it. Differential Revision: [D18357424](https://our.internmc.facebook.com/intern/diff/D18357424/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Nov 18, 2019
Pull Request resolved: #29330 This makes for a nicer API, especially in backend fallback kernels who get an OperatorHandle instance and can directly call these methods on it. ghstack-source-id: 94138628 Differential Revision: [D18357424](https://our.internmc.facebook.com/intern/diff/D18357424/)
This makes for a nicer API, especially in backend fallback kernels who get an OperatorHandle instance and can directly call these methods on it. Differential Revision: [D18357424](https://our.internmc.facebook.com/intern/diff/D18357424/) [ghstack-poisoned]
This was referenced Nov 22, 2019
This makes for a nicer API, especially in backend fallback kernels who get an OperatorHandle instance and can directly call these methods on it. Differential Revision: [D18357424](https://our.internmc.facebook.com/intern/diff/D18357424/) [ghstack-poisoned]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This makes for a nicer API, especially in backend fallback kernels who get an OperatorHandle instance and can directly call these methods on it.
Differential Revision: D18357424