Test cases for backend fallback kernels#29214
Closed
smessmer wants to merge 19 commits intogh/smessmer/111/basefrom
Closed
Test cases for backend fallback kernels#29214smessmer wants to merge 19 commits intogh/smessmer/111/basefrom
smessmer wants to merge 19 commits intogh/smessmer/111/basefrom
Conversation
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
This was referenced Nov 5, 2019
smessmer
added a commit
that referenced
this pull request
Nov 5, 2019
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) ghstack-source-id: 93287837 Pull Request resolved: #29214
ezyang
approved these changes
Nov 5, 2019
Contributor
ezyang
left a comment
There was a problem hiding this comment.
These tests are fine but they are not the same as the old boxed fallback tests, which showed you how to use backend fallback to do something more similar to what you /actually/ want to do (fallthrough to the underlying kernel, and do some other stuff along the way.)
Contributor
|
(So, I'm not blocking landing this PR, but I don't think @mcarilli will really be satisfied by these tests.) |
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Nov 6, 2019
Pull Request resolved: #29214 - ghstack-source-id: 93345601 Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/)
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Nov 6, 2019
Pull Request resolved: #29214 - ghstack-source-id: 93383485 Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/)
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Nov 6, 2019
Pull Request resolved: #29214 - ghstack-source-id: 93389158 Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/)
This was referenced Nov 6, 2019
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
Contributor
Author
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
This was referenced Nov 22, 2019
- Differential Revision: [D18329308](https://our.internmc.facebook.com/intern/diff/D18329308/) [ghstack-poisoned]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D18329308