Closed
Conversation
Remove callUnboxedOnly() and instead use metaprogramming to figure out if an operator can use a boxed fallback or not. This enables boxed fallback for ops in native_functions.yaml even if they don't have `use_c10_dispatcher: full` set, as long as they're in the range of supported types. Differential Revision: [D18462653](https://our.internmc.facebook.com/intern/diff/D18462653/) [ghstack-poisoned]
This was referenced Nov 12, 2019
Closed
Remove callUnboxedOnly() and instead use metaprogramming to figure out if an operator can use a boxed fallback or not. This enables boxed fallback for ops in native_functions.yaml even if they don't have `use_c10_dispatcher: full` set, as long as they're in the range of supported types. Differential Revision: [D18462653](https://our.internmc.facebook.com/intern/diff/D18462653/) [ghstack-poisoned]
Contributor
|
There is a lot of irrelevant code motion in this PR, which makes it hard to read the diff. Could you please explain what happened? |
ezyang
reviewed
Nov 13, 2019
ezyang
reviewed
Nov 13, 2019
|
|
||
| namespace c10 { | ||
|
|
||
| inline KernelFunction::KernelFunction() |
Contributor
There was a problem hiding this comment.
Are there any changes to this file?
Contributor
Author
There was a problem hiding this comment.
callUnboxed now calls into impl::boxAndCallBoxedFunc instead of detail::boxAndCallBoxedFunc and that function implementation moved into its own header boxing.h. That's also the reason why this whole code movement happens - there's a dependency cycle between KernelFunction.h and boxing.h that I'm resolving by creating a KernelFunction_impl.h.
Contributor
There was a problem hiding this comment.
OK... but did you change any of the code in this file? :)
Contributor
Author
There was a problem hiding this comment.
This file is new and it has all the KernelFunction methods. The code inside the methods is unchanged except for what I mentioned above.
Remove callUnboxedOnly() and instead use metaprogramming to figure out if an operator can use a boxed fallback or not. This enables boxed fallback for ops in native_functions.yaml even if they don't have `use_c10_dispatcher: full` set, as long as they're in the range of supported types. Differential Revision: [D18462653](https://our.internmc.facebook.com/intern/diff/D18462653/) [ghstack-poisoned]
Remove callUnboxedOnly() and instead use metaprogramming to figure out if an operator can use a boxed fallback or not. This enables boxed fallback for ops in native_functions.yaml even if they don't have `use_c10_dispatcher: full` set, as long as they're in the range of supported types. Differential Revision: [D18462653](https://our.internmc.facebook.com/intern/diff/D18462653/) [ghstack-poisoned]
Remove callUnboxedOnly() and instead use metaprogramming to figure out if an operator can use a boxed fallback or not. This enables boxed fallback for ops in native_functions.yaml even if they don't have `use_c10_dispatcher: full` set, as long as they're in the range of supported types. Differential Revision: [D18462653](https://our.internmc.facebook.com/intern/diff/D18462653/) [ghstack-poisoned]
ezyang
approved these changes
Nov 15, 2019
Remove callUnboxedOnly() and instead use metaprogramming to figure out if an operator can use a boxed fallback or not. This enables boxed fallback for ops in native_functions.yaml even if they don't have `use_c10_dispatcher: full` set, as long as they're in the range of supported types. Differential Revision: [D18462653](https://our.internmc.facebook.com/intern/diff/D18462653/) [ghstack-poisoned]
Remove callUnboxedOnly() and instead use metaprogramming to figure out if an operator can use a boxed fallback or not. This enables boxed fallback for ops in native_functions.yaml even if they don't have `use_c10_dispatcher: full` set, as long as they're in the range of supported types. Differential Revision: [D18462653](https://our.internmc.facebook.com/intern/diff/D18462653/) [ghstack-poisoned]
Remove callUnboxedOnly() and instead use metaprogramming to figure out if an operator can use a boxed fallback or not. This enables boxed fallback for ops in native_functions.yaml even if they don't have `use_c10_dispatcher: full` set, as long as they're in the range of supported types. Differential Revision: [D18462653](https://our.internmc.facebook.com/intern/diff/D18462653/) [ghstack-poisoned]
Remove callUnboxedOnly() and instead use metaprogramming to figure out if an operator can use a boxed fallback or not. This enables boxed fallback for ops in native_functions.yaml even if they don't have `use_c10_dispatcher: full` set, as long as they're in the range of supported types. Differential Revision: [D18462653](https://our.internmc.facebook.com/intern/diff/D18462653/) [ghstack-poisoned]
Remove callUnboxedOnly() and instead use metaprogramming to figure out if an operator can use a boxed fallback or not. This enables boxed fallback for ops in native_functions.yaml even if they don't have `use_c10_dispatcher: full` set, as long as they're in the range of supported types. Differential Revision: [D18462653](https://our.internmc.facebook.com/intern/diff/D18462653/) [ghstack-poisoned]
Remove callUnboxedOnly() and instead use metaprogramming to figure out if an operator can use a boxed fallback or not. This enables boxed fallback for ops in native_functions.yaml even if they don't have `use_c10_dispatcher: full` set, as long as they're in the range of supported types. Differential Revision: [D18462653](https://our.internmc.facebook.com/intern/diff/D18462653/) [ghstack-poisoned]
This was referenced Nov 22, 2019
Remove callUnboxedOnly() and instead use metaprogramming to figure out if an operator can use a boxed fallback or not. This enables boxed fallback for ops in native_functions.yaml even if they don't have `use_c10_dispatcher: full` set, as long as they're in the range of supported types. Differential Revision: [D18462653](https://our.internmc.facebook.com/intern/diff/D18462653/) [ghstack-poisoned]
Remove callUnboxedOnly() and instead use metaprogramming to figure out if an operator can use a boxed fallback or not. This enables boxed fallback for ops in native_functions.yaml even if they don't have `use_c10_dispatcher: full` set, as long as they're in the range of supported types. Differential Revision: [D18462653](https://our.internmc.facebook.com/intern/diff/D18462653/) [ghstack-poisoned]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Remove callUnboxedOnly() and instead use metaprogramming to figure out if an operator can use a boxed fallback or not.
This enables boxed fallback for ops in native_functions.yaml even if they don't have
use_c10_dispatcher: fullset, as long as they're in the range of supported types.Differential Revision: D18462653