Add a OperatorHandle argument to boxed kernels#29201
Closed
smessmer wants to merge 21 commits intogh/smessmer/109/basefrom
Closed
Add a OperatorHandle argument to boxed kernels#29201smessmer wants to merge 21 commits intogh/smessmer/109/basefrom
smessmer wants to merge 21 commits intogh/smessmer/109/basefrom
Conversation
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/) [ghstack-poisoned]
This was referenced Nov 5, 2019
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Nov 5, 2019
Pull Request resolved: #29201 This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. ghstack-source-id: 93276980 Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/)
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Nov 5, 2019
Pull Request resolved: #29201 This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. ghstack-source-id: 93280246 Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/)
ezyang
approved these changes
Nov 5, 2019
Contributor
ezyang
left a comment
There was a problem hiding this comment.
Have we audited the OperatorHandle API so that it is OK to make public?
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/) [ghstack-poisoned]
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/) [ghstack-poisoned]
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/) [ghstack-poisoned]
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/) [ghstack-poisoned]
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/) [ghstack-poisoned]
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/) [ghstack-poisoned]
This was referenced Nov 6, 2019
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/) [ghstack-poisoned]
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/) [ghstack-poisoned]
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/) [ghstack-poisoned]
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/) [ghstack-poisoned]
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/) [ghstack-poisoned]
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/) [ghstack-poisoned]
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/) [ghstack-poisoned]
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/) [ghstack-poisoned]
Contributor
Author
|
Which part of the API exactly? This is the current API, but I don't think it's stable yet. The |
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/) [ghstack-poisoned]
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/) [ghstack-poisoned]
mcarilli
pushed a commit
to mcarilli/pytorch
that referenced
this pull request
Nov 19, 2019
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/) [ghstack-poisoned]
This was referenced Nov 22, 2019
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called. Differential Revision: [D18282746](https://our.internmc.facebook.com/intern/diff/D18282746/) [ghstack-poisoned]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This is required for boxed backend fallback kernels (e.g. lazy, AMP) because they need to know which op was actually called.
Differential Revision: D18282746