[wip] Use codegen'ed unboxing wrappers#30370
[wip] Use codegen'ed unboxing wrappers#30370smessmer wants to merge 12 commits intogh/smessmer/124/basefrom
Conversation
Not all ops support the templated unboxing wrappers yet. For the ones that don't, let's use the codegen'ed unboxing wrappers from register_aten_ops.cpp, but register them with c10 directly instead of JIT. This temporary hack will allow us to get mobile working much faster, but the plan is to remove this hack again once all ops support the templated unboxing wrapper. Differential Revision: [D18672405](https://our.internmc.facebook.com/intern/diff/D18672405/) [ghstack-poisoned]
Not all ops support the templated unboxing wrappers yet. For the ones that don't, let's use the codegen'ed unboxing wrappers from register_aten_ops.cpp, but register them with c10 directly instead of JIT. This temporary hack will allow us to get mobile working much faster, but the plan is to remove this hack again once all ops support the templated unboxing wrapper. Differential Revision: [D18672405](https://our.internmc.facebook.com/intern/diff/D18672405/) ghstack-source-id: 94481318 Pull Request resolved: #30370
Not all ops support the templated unboxing wrappers yet. For the ones that don't, let's use the codegen'ed unboxing wrappers from register_aten_ops.cpp, but register them with c10 directly instead of JIT. This temporary hack will allow us to get mobile working much faster, but the plan is to remove this hack again once all ops support the templated unboxing wrapper. Differential Revision: [D18672405](https://our.internmc.facebook.com/intern/diff/D18672405/) [ghstack-poisoned]
Not all ops support the templated unboxing wrappers yet. For the ones that don't, let's use the codegen'ed unboxing wrappers from register_aten_ops.cpp, but register them with c10 directly instead of JIT. This temporary hack will allow us to get mobile working much faster, but the plan is to remove this hack again once all ops support the templated unboxing wrapper. Differential Revision: [D18672405](https://our.internmc.facebook.com/intern/diff/D18672405/) [ghstack-poisoned]
Pull Request resolved: #30370 Not all ops support the templated unboxing wrappers yet. For the ones that don't, let's use the codegen'ed unboxing wrappers from register_aten_ops.cpp, but register them with c10 directly instead of JIT. This temporary hack will allow us to get mobile working much faster, but the plan is to remove this hack again once all ops support the templated unboxing wrapper. ghstack-source-id: 94499786 Differential Revision: [D18672405](https://our.internmc.facebook.com/intern/diff/D18672405/)
Not all ops support the templated unboxing wrappers yet. For the ones that don't, let's use the codegen'ed unboxing wrappers from register_aten_ops.cpp, but register them with c10 directly instead of JIT. This temporary hack will allow us to get mobile working much faster, but the plan is to remove this hack again once all ops support the templated unboxing wrapper. Differential Revision: [D18672405](https://our.internmc.facebook.com/intern/diff/D18672405/) [ghstack-poisoned]
Pull Request resolved: #30370 Not all ops support the templated unboxing wrappers yet. For the ones that don't, let's use the codegen'ed unboxing wrappers from register_aten_ops.cpp, but register them with c10 directly instead of JIT. This temporary hack will allow us to get mobile working much faster, but the plan is to remove this hack again once all ops support the templated unboxing wrapper. ghstack-source-id: 95812247 Differential Revision: [D18672405](https://our.internmc.facebook.com/intern/diff/D18672405/)
💊 CircleCI build failures summary and remediationsAs of commit 51c4532:
Detailed failure analysisOne may explore the probable reasons each build failed interactively on the Dr. CI website. 🕵️ 12 new failures recognized by patternsThe following build failures do not appear to be due to upstream breakage:
|
Not all ops support the templated unboxing wrappers yet. For the ones that don't, let's use the codegen'ed unboxing wrappers from register_aten_ops.cpp, but register them with c10 directly instead of JIT. This temporary hack will allow us to get mobile working much faster, but the plan is to remove this hack again once all ops support the templated unboxing wrapper. Differential Revision: [D18672405](https://our.internmc.facebook.com/intern/diff/D18672405/) [ghstack-poisoned]
Not all ops support the templated unboxing wrappers yet. For the ones that don't, let's use the codegen'ed unboxing wrappers from register_aten_ops.cpp, but register them with c10 directly instead of JIT. This temporary hack will allow us to get mobile working much faster, but the plan is to remove this hack again once all ops support the templated unboxing wrapper. Differential Revision: [D18672405](https://our.internmc.facebook.com/intern/diff/D18672405/) [ghstack-poisoned]
Pull Request resolved: #30370 Not all ops support the templated unboxing wrappers yet. For the ones that don't, let's use the codegen'ed unboxing wrappers from register_aten_ops.cpp, but register them with c10 directly instead of JIT. This temporary hack will allow us to get mobile working much faster, but the plan is to remove this hack again once all ops support the templated unboxing wrapper. ghstack-source-id: 95878675 Differential Revision: [D18672405](https://our.internmc.facebook.com/intern/diff/D18672405/)
Not all ops support the templated unboxing wrappers yet. For the ones that don't, let's use the codegen'ed unboxing wrappers from register_aten_ops.cpp, but register them with c10 directly instead of JIT. This temporary hack will allow us to get mobile working much faster, but the plan is to remove this hack again once all ops support the templated unboxing wrapper. Differential Revision: [D18672405](https://our.internmc.facebook.com/intern/diff/D18672405/) [ghstack-poisoned]
Pull Request resolved: #30370 Not all ops support the templated unboxing wrappers yet. For the ones that don't, let's use the codegen'ed unboxing wrappers from register_aten_ops.cpp, but register them with c10 directly instead of JIT. This temporary hack will allow us to get mobile working much faster, but the plan is to remove this hack again once all ops support the templated unboxing wrapper. ghstack-source-id: 96369463 Differential Revision: [D18672405](https://our.internmc.facebook.com/intern/diff/D18672405/)
Not all ops support the templated unboxing wrappers yet. For the ones that don't, let's use the codegen'ed unboxing wrappers from register_aten_ops.cpp, but register them with c10 directly instead of JIT. This temporary hack will allow us to get mobile working much faster, but the plan is to remove this hack again once all ops support the templated unboxing wrapper. Differential Revision: [D18672405](https://our.internmc.facebook.com/intern/diff/D18672405/) [ghstack-poisoned]
Not all ops support the templated unboxing wrappers yet. For the ones that don't, let's use the codegen'ed unboxing wrappers from register_aten_ops.cpp, but register them with c10 directly instead of JIT. This temporary hack will allow us to get mobile working much faster, but the plan is to remove this hack again once all ops support the templated unboxing wrapper. Differential Revision: [D18672405](https://our.internmc.facebook.com/intern/diff/D18672405/) [ghstack-poisoned]
Not all ops support the templated unboxing wrappers yet. For the ones that don't, let's use the codegen'ed unboxing wrappers from register_aten_ops.cpp, but register them with c10 directly instead of JIT. The `use_c10_dispatcher` setting in `native_functions.yaml` now has a new option 'with_codegenerated_unboxing_wrapper' which means we take the codegened unboxing wrapper from register_aten_ops.cpp and stuff it into c10. This new argument is the default, 'unboxed_only' is not the default anymore. For the ops that don't support boxed dispatch yet (i.e. ops taking TensorOptions arguments), we set them to 'unboxed_only' and they follow the old behavior of having register_aten_ops.cpp register the jit op. This temporary hack will allow us to get mobile working much faster, but the plan is to remove this hack again once all ops support the templated unboxing wrapper. Differential Revision: [D18672405](https://our.internmc.facebook.com/intern/diff/D18672405/) [ghstack-poisoned]
Not all ops support the templated unboxing wrappers yet. For the ones that don't, let's use the codegen'ed unboxing wrappers from register_aten_ops.cpp, but register them with c10 directly instead of JIT. The `use_c10_dispatcher` setting in `native_functions.yaml` now has a new option 'with_codegenerated_unboxing_wrapper' which means we take the codegened unboxing wrapper from register_aten_ops.cpp and stuff it into c10. This new argument is the default, 'unboxed_only' is not the default anymore. For the ops that don't support boxed dispatch yet (i.e. ops taking TensorOptions arguments), we set them to 'unboxed_only' and they follow the old behavior of having register_aten_ops.cpp register the jit op. This temporary hack will allow us to get mobile working much faster, but the plan is to remove this hack again once all ops support the templated unboxing wrapper. Differential Revision: [D18672405](https://our.internmc.facebook.com/intern/diff/D18672405/) [ghstack-poisoned]
Pull Request resolved: #30370 Not all ops support the templated unboxing wrappers yet. For the ones that don't, let's use the codegen'ed unboxing wrappers from register_aten_ops.cpp, but register them with c10 directly instead of JIT. The `use_c10_dispatcher` setting in `native_functions.yaml` now has a new option 'with_codegenerated_unboxing_wrapper' which means we take the codegened unboxing wrapper from register_aten_ops.cpp and stuff it into c10. This new argument is the default, 'unboxed_only' is not the default anymore. For the ops that don't support boxed dispatch yet (i.e. ops taking TensorOptions arguments), we set them to 'unboxed_only' and they follow the old behavior of having register_aten_ops.cpp register the jit op. This temporary hack will allow us to get mobile working much faster, but the plan is to remove this hack again once all ops support the templated unboxing wrapper. ghstack-source-id: 96798469 Differential Revision: [D18672405](https://our.internmc.facebook.com/intern/diff/D18672405/)
Not all ops support the templated unboxing wrappers yet. For the ones that don't, let's use the codegen'ed unboxing wrappers from register_aten_ops.cpp, but register them with c10 directly instead of JIT. The `use_c10_dispatcher` setting in `native_functions.yaml` now has a new option 'with_codegenerated_unboxing_wrapper' which means we take the codegened unboxing wrapper from register_aten_ops.cpp and stuff it into c10. This new argument is the default, 'unboxed_only' is not the default anymore. For the ops that don't support boxed dispatch yet (i.e. ops taking TensorOptions arguments), we set them to 'unboxed_only' and they follow the old behavior of having register_aten_ops.cpp register the jit op. This temporary hack will allow us to get mobile working much faster, but the plan is to remove this hack again once all ops support the templated unboxing wrapper. Differential Revision: [D18672405](https://our.internmc.facebook.com/intern/diff/D18672405/) [ghstack-poisoned]
Pull Request resolved: pytorch/pytorch#30370 Not all ops support the templated unboxing wrappers yet. For the ones that don't, let's use the codegen'ed unboxing wrappers from register_aten_ops.cpp, but register them with c10 directly instead of JIT. The `use_c10_dispatcher` setting in `native_functions.yaml` now has a new option 'with_codegenerated_unboxing_wrapper' which means we take the codegened unboxing wrapper from register_aten_ops.cpp and stuff it into c10. This new argument is the default, 'unboxed_only' is not the default anymore. For the ops that don't support boxed dispatch yet (i.e. ops taking TensorOptions arguments), we set them to 'unboxed_only' and they follow the old behavior of having register_aten_ops.cpp register the jit op. This temporary hack will allow us to get mobile working much faster, but the plan is to remove this hack again once all ops support the templated unboxing wrapper. ghstack-source-id: 96979487 Differential Revision: [D18672405](https://our.internmc.facebook.com/intern/diff/D18672405/)
Stack from ghstack:
Not all ops support the templated unboxing wrappers yet. For the ones that don't,
let's use the codegen'ed unboxing wrappers from register_aten_ops.cpp, but register
them with c10 directly instead of JIT.
The
use_c10_dispatchersetting innative_functions.yamlnow has a new option 'with_codegenerated_unboxing_wrapper' which means we take the codegened unboxing wrapper from register_aten_ops.cpp and stuff it into c10. This new argument is the default, 'unboxed_only' is not the default anymore. For the ops that don't support boxed dispatch yet (i.e. ops taking TensorOptions arguments), we set them to 'unboxed_only' and they follow the old behavior of having register_aten_ops.cpp register the jit op.This temporary hack will allow us to get mobile working much faster, but the plan is
to remove this hack again once all ops support the templated unboxing wrapper.
Differential Revision: D18672405