Skip to content

BUG: Cope with indirect objects in filters and remove deprecated code#2177

Merged
MartinThoma merged 11 commits intopy-pdf:mainfrom
pubpub-zz:iss2153
Sep 10, 2023
Merged

BUG: Cope with indirect objects in filters and remove deprecated code#2177
MartinThoma merged 11 commits intopy-pdf:mainfrom
pubpub-zz:iss2153

Conversation

@pubpub-zz
Copy link
Copy Markdown
Collaborator

@pubpub-zz pubpub-zz commented Sep 8, 2023

closes #2158
closes #2159

@pubpub-zz
Copy link
Copy Markdown
Collaborator Author

@MartinThoma the coverage analysis failed. Can you rerun-it?

@MartinThoma MartinThoma changed the title BUG: cope with indirect objects in filters and remove depreciated code BUG: Cope with indirect objects in filters and remove deprecated code Sep 9, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09% 🎉

Comparison is base (f68138c) 94.25% compared to head (a64378a) 94.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2177      +/-   ##
==========================================
+ Coverage   94.25%   94.34%   +0.09%     
==========================================
  Files          43       43              
  Lines        7573     7572       -1     
  Branches     1494     1488       -6     
==========================================
+ Hits         7138     7144       +6     
+ Misses        268      263       -5     
+ Partials      167      165       -2     
Files Changed Coverage Δ
pypdf/filters.py 96.77% <100.00%> (+1.72%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MartinThoma
Copy link
Copy Markdown
Member

The PR overall increased coverage, but this is not covered:

image

@MartinThoma
Copy link
Copy Markdown
Member

I'll take care of that. I don't think we should cover that

@MartinThoma MartinThoma added the soon PRs that are almost ready to be merged, issues that get solved pretty soon label Sep 10, 2023
pubpub-zz and others added 2 commits September 10, 2023 11:15
Co-authored-by: Martin Thoma <info@martin-thoma.de>
@MartinThoma
Copy link
Copy Markdown
Member

from ._utils import deprecation_no_replacement

is missing

@MartinThoma MartinThoma merged commit 0ca4d37 into py-pdf:main Sep 10, 2023
MartinThoma added a commit that referenced this pull request Sep 10, 2023
## What's new

### Security (SEC)
-  Infinite recursion caused by IndirectObject clone (#2156)

### New Features (ENH)
-  Ease access to ViewerPreferences (#2144)

### Bug Fixes (BUG)
-  catch the case where w[0] is an IndirectObject instead of an int (#2154)
-  Cope with indirect objects in filters and remove deprecated code (#2177)
-  Cope with extra space (#2151)
-  Merge pages without resources (#2150)
-  getcontents() shall return None if contents is NullObject (#2161)
-  Fix conversion from 1 to LA (#2175)
-  Accept tabs in cmaps (#2174)

### Robustness (ROB)
-  Accept XYZ with no arguments (#2178)

[Full Changelog](3.15.5...3.16.0)
@pubpub-zz pubpub-zz deleted the iss2153 branch August 9, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

soon PRs that are almost ready to be merged, issues that get solved pretty soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possibly undefined variable in FlateDecode.decode if parameters are an ArrayObject FlateDecode will fail if columns are an IndirectObject

2 participants