Skip to content

BUG: getcontents() shall return None if contents is NullObject#2161

Merged
MartinThoma merged 1 commit intopy-pdf:mainfrom
pubpub-zz:iss2157
Sep 10, 2023
Merged

BUG: getcontents() shall return None if contents is NullObject#2161
MartinThoma merged 1 commit intopy-pdf:mainfrom
pubpub-zz:iss2157

Conversation

@pubpub-zz
Copy link
Copy Markdown
Collaborator

closes #2157

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (05f2a65) 94.25% compared to head (c84777b) 94.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2161   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files          42       42           
  Lines        7556     7559    +3     
  Branches     1487     1488    +1     
=======================================
+ Hits         7122     7125    +3     
  Misses        266      266           
  Partials      168      168           
Files Changed Coverage Δ
pypdf/_page.py 93.69% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pubpub-zz
Copy link
Copy Markdown
Collaborator Author

@MartinThoma
all yours

@MartinThoma MartinThoma merged commit bf62f17 into py-pdf:main Sep 10, 2023
MartinThoma added a commit that referenced this pull request Sep 10, 2023
## What's new

### Security (SEC)
-  Infinite recursion caused by IndirectObject clone (#2156)

### New Features (ENH)
-  Ease access to ViewerPreferences (#2144)

### Bug Fixes (BUG)
-  catch the case where w[0] is an IndirectObject instead of an int (#2154)
-  Cope with indirect objects in filters and remove deprecated code (#2177)
-  Cope with extra space (#2151)
-  Merge pages without resources (#2150)
-  getcontents() shall return None if contents is NullObject (#2161)
-  Fix conversion from 1 to LA (#2175)
-  Accept tabs in cmaps (#2174)

### Robustness (ROB)
-  Accept XYZ with no arguments (#2178)

[Full Changelog](3.15.5...3.16.0)
@pubpub-zz pubpub-zz deleted the iss2157 branch August 9, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Page merge: 'NullObject' object has no attribute 'get_data'

2 participants