SEC: Infinite recursion caused by IndirectObject clone#2156
Merged
MartinThoma merged 1 commit intopy-pdf:mainfrom Sep 10, 2023
Merged
SEC: Infinite recursion caused by IndirectObject clone#2156MartinThoma merged 1 commit intopy-pdf:mainfrom
MartinThoma merged 1 commit intopy-pdf:mainfrom
Conversation
if a object contains a indirect_reference, which points to the object it self, cloning it will cause infinite recursion. for example: a page contains a link to self.
54ac2b7 to
81eb779
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2156 +/- ##
==========================================
+ Coverage 94.25% 94.28% +0.03%
==========================================
Files 42 42
Lines 7556 7561 +5
Branches 1487 1488 +1
==========================================
+ Hits 7122 7129 +7
+ Misses 266 265 -1
+ Partials 168 167 -1
☔ View full report in Codecov by Sentry. |
Collaborator
|
Missed your PR. Wonderfull |
Contributor
Author
|
@pubpub-zz thank you. |
Member
|
Thank you :-) |
MartinThoma
added a commit
that referenced
this pull request
Sep 10, 2023
## What's new ### Security (SEC) - Infinite recursion caused by IndirectObject clone (#2156) ### New Features (ENH) - Ease access to ViewerPreferences (#2144) ### Bug Fixes (BUG) - catch the case where w[0] is an IndirectObject instead of an int (#2154) - Cope with indirect objects in filters and remove deprecated code (#2177) - Cope with extra space (#2151) - Merge pages without resources (#2150) - getcontents() shall return None if contents is NullObject (#2161) - Fix conversion from 1 to LA (#2175) - Accept tabs in cmaps (#2174) ### Robustness (ROB) - Accept XYZ with no arguments (#2178) [Full Changelog](3.15.5...3.16.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if a object contains a indirect_reference, which points to the object it self, cloning it will cause infinite recursion.
for example: a page contains a link to self.
this will fix #2102