ENH: Ease access to ViewerPreferences by pubpub-zz · Pull Request #2144 · py-pdf/pypdf

pubpub-zz · 2023-09-03T16:09:01Z

closes #2105
still doc and test to be fixed/added

closes py-pdf#2105 still doc and test to be fixed/added

pubpub-zz · 2023-09-03T16:09:28Z

@MartinThoma
Can you give me your opinion on this first part

"== True" is different from "is True"

codecov · 2023-09-03T17:40:19Z

Codecov Report

Patch coverage: 97.75% and project coverage change: +0.09% 🎉

Comparison is base (301b542) 94.13% compared to head (2d487b1) 94.22%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2144      +/-   ##
==========================================
+ Coverage   94.13%   94.22%   +0.09%     
==========================================
  Files          41       42       +1     
  Lines        7467     7556      +89     
  Branches     1474     1487      +13     
==========================================
+ Hits         7029     7120      +91     
+ Misses        273      268       -5     
- Partials      165      168       +3

Files Changed	Coverage Δ
pypdf/_reader.py	`91.69% <88.88%> (-0.03%)`	⬇️
pypdf/_writer.py	`88.25% <94.11%> (+0.41%)`	⬆️
pypdf/generic/__init__.py	`100.00% <100.00%> (ø)`
pypdf/generic/_viewerpref.py	`100.00% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

"== True" is different from "is True"

pubpub-zz · 2023-09-03T20:15:25Z

@MartinThoma I've been as far as possible. I have not been able to check if documentation is properly generated

tests/test_writer.py

MartinThoma · 2023-09-03T20:47:53Z

Looks good to me :-) Nice work 🚀

I've seen that there was a draft PR: https://github.com/py-pdf/pypdf/commit/c95b694068d00184dfc8a9b7dceabf7446839ccd.patch

If you used that one, I would mere it with Co-authored-by: Marc Stober if that is also fine to you. If you didn't use that one or if you don't think that makes sense, I'll merge it as it is. Just let me know :-)

pubpub-zz · 2023-09-03T20:52:10Z

Looks good to me :-) Nice work 🚀

I've seen that there was a draft PR: https://github.com/py-pdf/pypdf/commit/c95b694068d00184dfc8a9b7dceabf7446839ccd.patch

If you used that one, I would mere it with Co-authored-by: Marc Stober if that is also fine to you. If you didn't use that one or if you don't think that makes sense, I'll merge it as it is. Just let me know :-)

I looked at it but there is a few errors. However I'm completly open to Co-authored it 😀

See #2144

## What's new ### Security (SEC) - Infinite recursion caused by IndirectObject clone (#2156) ### New Features (ENH) - Ease access to ViewerPreferences (#2144) ### Bug Fixes (BUG) - catch the case where w[0] is an IndirectObject instead of an int (#2154) - Cope with indirect objects in filters and remove deprecated code (#2177) - Cope with extra space (#2151) - Merge pages without resources (#2150) - getcontents() shall return None if contents is NullObject (#2161) - Fix conversion from 1 to LA (#2175) - Accept tabs in cmaps (#2174) ### Robustness (ROB) - Accept XYZ with no arguments (#2178) [Full Changelog](3.15.5...3.16.0)

ENH : ease access to ViewerPreferences

6f3a50e

closes py-pdf#2105 still doc and test to be fixed/added

pubpub-zz added 2 commits September 3, 2023 19:11

add Test + fixes

3675ba8

fix issue with wrong substitution

2ed8da3

"== True" is different from "is True"

pubpub-zz added 4 commits September 3, 2023 19:58

fix issue with wrong substitution

bb770c0

"== True" is different from "is True"

Merge remote-tracking branch 'origin/viewer_pref' into viewer_pref

2299720

coverage+fix

7e3251c

coverage

2d487b1

MartinThoma changed the title ~~ENH : ease access to ViewerPreferences~~ ENH: Ease access to ViewerPreferences Sep 3, 2023

MartinThoma reviewed Sep 3, 2023

View reviewed changes