👍
can you please add also a test, using the file you are reference and just extracting the text in page[0] (no need to assert any results) : that will prevent the issue to come back

👍 can you please add also a test, using the file you are reference and just extracting the text in page[0] (no need to assert any results) : that will prevent the issue to come back

Will do, would you want it inside an existing test file, or a separate one?

And I assume the file goes to resources/, right?

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0ca4d37) 94.34% compared to head (dc0c8b5) 94.34%.

@@           Coverage Diff           @@
##             main    #2154   +/-   ##
=======================================
  Coverage   94.34%   94.34%           
=======================================
  Files          43       43           
  Lines        7572     7572           
  Branches     1488     1488           
=======================================
  Hits         7144     7144           
  Misses        263      263           
  Partials      165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

It sounds good to add it to test_cmap.py

And I assume the file goes to resources/, right?

You will find some examples of files being downloaded on-the-fly inside the test code, see

And I assume the file goes to resources/, right?

You will find some examples of files being downloaded on-the-fly inside the test code, see

pypdf/tests/test_writer.py

Lines 1040 to 1044 in 05f2a65

	@pytest.mark.enable_socket()
	def test_iss471():
	url = "https://github.com/py-pdf/pypdf/files/9139245/book.pdf"
	name = "book_471.pdf"
	reader = PdfReader(BytesIO(get_data_from_url(url, name=name)))

for example. This especially holds true if you do not hold all required rights on the test files itself and cannot comply with the terms in https://github.com/py-pdf/sample-files#licenses.

The file I need is from arxiv, should be pretty easy to get a direct link. Thanks for the pointers.

you should use https://github.com/py-pdf/pypdf/files/12489914/Morris.et.al.-.2020.-.TextAttack.A.Framework.for.Adversarial.Attacks.Data.Augmentation.and.Adversarial.Training.in.NLP.pdf which is already within discussion

you should use https://github.com/py-pdf/pypdf/files/12489914/Morris.et.al.-.2020.-.TextAttack.A.Framework.for.Adversarial.Attacks.Data.Augmentation.and.Adversarial.Training.in.NLP.pdf which is already within discussion

The URL is too long to pass the code style check, I used the file directly from arxiv instead. But if file within github is preferred, I can shorten the file name and upload again.

Well done, @rraval !

I've just merged it and will release soon. If you want, I can add you to https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html

Well done, @rraval !

I've just merged it and will release soon. If you want, I can add you to https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html

Sure, that sounds nice. Thanks.