Skip to content

BUG: Merge pages without resources#2150

Merged
MartinThoma merged 3 commits intopy-pdf:mainfrom
pubpub-zz:iss2147
Sep 10, 2023
Merged

BUG: Merge pages without resources#2150
MartinThoma merged 3 commits intopy-pdf:mainfrom
pubpub-zz:iss2147

Conversation

@pubpub-zz
Copy link
Copy Markdown
Collaborator

closes #2147

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (e090717) 94.24% compared to head (6364f60) 94.26%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2150      +/-   ##
==========================================
+ Coverage   94.24%   94.26%   +0.01%     
==========================================
  Files          43       43              
  Lines        7576     7580       +4     
  Branches     1491     1493       +2     
==========================================
+ Hits         7140     7145       +5     
  Misses        268      268              
+ Partials      168      167       -1     
Files Changed Coverage Δ
pypdf/_page.py 94.06% <100.00%> (+0.14%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MartinThoma MartinThoma changed the title BUG : merge pages without resources BUG: Merge pages without resources Sep 10, 2023
@MartinThoma MartinThoma added the soon PRs that are almost ready to be merged, issues that get solved pretty soon label Sep 10, 2023
@MartinThoma MartinThoma merged commit 5a42b96 into py-pdf:main Sep 10, 2023
@MartinThoma MartinThoma removed the soon PRs that are almost ready to be merged, issues that get solved pretty soon label Sep 10, 2023
@MartinThoma
Copy link
Copy Markdown
Member

Thank you 🤗

MartinThoma added a commit that referenced this pull request Sep 10, 2023
## What's new

### Security (SEC)
-  Infinite recursion caused by IndirectObject clone (#2156)

### New Features (ENH)
-  Ease access to ViewerPreferences (#2144)

### Bug Fixes (BUG)
-  catch the case where w[0] is an IndirectObject instead of an int (#2154)
-  Cope with indirect objects in filters and remove deprecated code (#2177)
-  Cope with extra space (#2151)
-  Merge pages without resources (#2150)
-  getcontents() shall return None if contents is NullObject (#2161)
-  Fix conversion from 1 to LA (#2175)
-  Accept tabs in cmaps (#2174)

### Robustness (ROB)
-  Accept XYZ with no arguments (#2178)

[Full Changelog](3.15.5...3.16.0)
@pubpub-zz pubpub-zz deleted the iss2147 branch August 9, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"KeyError: '/Resources'" on page merge

2 participants