Fix deadlock on removeExpiredSnapshots#2461
Merged
ti-srebot merged 1 commit intopingcap:masterfrom Jul 22, 2021
Merged
Conversation
Add failpoint for testing Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Contributor
Author
|
/merge |
Collaborator
|
/run-all-tests |
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Aug 4, 2021
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Aug 4, 2021
Contributor
Author
|
/run-cherry-pick |
Contributor
Author
|
cherry-pick to release-5.1 in #2564 |
Collaborator
|
cherry pick to release-4.0 in PR #2567 |
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Aug 4, 2021
Contributor
Author
|
cherry-pick to release-5.0 in #2568 |
flowbehappy
pushed a commit
that referenced
this pull request
Aug 4, 2021
* Ignore sequence hole among PageFile meta (#2312) * Fix bug for GC may skip unexpected WriteBatches (#2356) * Add length check while running PageStorage GC (#2394) * PageStorage skip non continuous sequence safely (#2435) * Fix PageStorage GC with high valid rate PageFile (#2436) * More debug info for DeltaTree (query_id, snapshot lifetime) (#2431) * Fix deadlock on `removeExpiredSnapshots` (#2461) * Add grafana panels for write throughput per instance (#2524)
JaySon-Huang
added a commit
that referenced
this pull request
Aug 10, 2021
* cherry pick #2461 to release-4.0 Co-authored-by: JaySon <tshent@qq.com> Co-authored-by: JaySon-Huang <jayson.hjs@gmail.com>
ti-chi-bot
pushed a commit
that referenced
this pull request
Sep 1, 2021
windtalker
added a commit
that referenced
this pull request
Sep 6, 2021
Co-authored-by: JaySon <tshent@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JaySon-Huang jayson.hjs@gmail.com
What problem does this PR solve?
Issue Number: close #2456
Problem Summary:
Similar to issue: #2249 PR: #2277
In
removeExpiredSnapshots, it may trigger the~Snapshotunderread_write_mutexbeing locked. It causes incursive deadlock.And we will call
removeExpiredSnapshotsevery minute after #2431 that reports the oldest snapshot to Prometheus.https://github.com/pingcap/tics/blob/e9f28c717902a4b22855970752a08ceca214cd01/dbms/src/Storages/Page/mvcc/VersionSetWithDelta.h#L313-L340
What is changed and how it works?
read_write_mutex, and only release those snapshots after the lock gets releasedRelated changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Tested by the stress testing in Fix broken page storage stress testing #2297 with 4 writers, 128 readers, and failpoint
random_slow_page_storage_remove_expired_snapshotsenabledSide effects
Release note