Fix bug for GC may skip unexpected WriteBatches#2356
Merged
ti-srebot merged 2 commits intopingcap:masterfrom Jul 9, 2021
Merged
Fix bug for GC may skip unexpected WriteBatches#2356ti-srebot merged 2 commits intopingcap:masterfrom
ti-srebot merged 2 commits intopingcap:masterfrom
Conversation
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Contributor
Author
|
/run-all-tests |
Contributor
|
/merge |
Collaborator
|
/run-all-tests |
This was referenced Jul 13, 2021
Closed
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Aug 4, 2021
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Aug 4, 2021
flowbehappy
pushed a commit
that referenced
this pull request
Aug 4, 2021
* Ignore sequence hole among PageFile meta (#2312) * Fix bug for GC may skip unexpected WriteBatches (#2356) * Add length check while running PageStorage GC (#2394) * PageStorage skip non continuous sequence safely (#2435) * Fix PageStorage GC with high valid rate PageFile (#2436) * More debug info for DeltaTree (query_id, snapshot lifetime) (#2431) * Fix deadlock on `removeExpiredSnapshots` (#2461) * Add grafana panels for write throughput per instance (#2524)
This was referenced Aug 4, 2021
JaySon-Huang
pushed a commit
that referenced
this pull request
Aug 5, 2021
* Ignore sequence hole among PageFile meta (#2312) * Fix bug for GC may skip unexpected WriteBatches (#2356) * Add length check while running PageStorage GC (#2394) * PageStorage skip non continuous sequence safely (#2435) * Fix PageStorage GC with high valid rate PageFile (#2436) Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JaySon-Huang jayson.hjs@gmail.com
What problem does this PR solve?
Issue Number: close #2317
Problem Summary: After recovering from the crash in the middle of writing, GC can not successfully move forward cause the sequence number of WriteBatch among WAL is not consecutive. #2312 allow skipping non-consecutive sequence number, but we should not remove any {Formal/Legacy/Checkpoint} PageFiles before running LegacyCompactor, or we may skip some WriteBatches while compacting legacy files.
What is changed and how it works?
Should not remove any {Formal/Legacy/Checkpoint} PageFiles before running LegacyCompactor, or we may skip some WriteBatches while compacting legacy files.
Add check and comments under debug mode.
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note