Add length check while running PageStorage GC#2394
Merged
ti-srebot merged 1 commit intopingcap:masterfrom Jul 13, 2021
Merged
Conversation
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Closed
Contributor
Author
|
/run-all-tests |
Collaborator
|
@SchrodingerZhu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: tiflash(slack). |
Contributor
|
/merge |
Collaborator
|
/run-all-tests |
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Jul 14, 2021
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Jul 14, 2021
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Jul 14, 2021
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Jul 21, 2021
flowbehappy
pushed a commit
that referenced
this pull request
Jul 21, 2021
* Revert "Revert skipping not consecutive sequence" This reverts commit 1cea4ef. * Add length check while running PageStorage GC (#2394) * PageStorage add PageFileID existence check for multi disk deployment (#2412) * Add query id for DT read result Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * Add failpoint for holding storage streams for long time Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * Add async metrics for oldest snapshot lifetime Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * Show longest snapshot lifetime on Grafana Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * calculating num of legacy independently Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * reading writable files Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * Add failpoint for testing skip non-continuous sequence Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * Stop Legacy compactor by the min persisted sequence Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * Fix other bugs Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * Make DataCompactor move GC forward when there are PageFiles with high valid rate/bytes Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * Split PageFile with valid pages and no valid pages Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * fix ut Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * enable fiu under release Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> * Fix the min persisted sequence Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Aug 4, 2021
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Aug 4, 2021
flowbehappy
pushed a commit
that referenced
this pull request
Aug 4, 2021
* Ignore sequence hole among PageFile meta (#2312) * Fix bug for GC may skip unexpected WriteBatches (#2356) * Add length check while running PageStorage GC (#2394) * PageStorage skip non continuous sequence safely (#2435) * Fix PageStorage GC with high valid rate PageFile (#2436) * More debug info for DeltaTree (query_id, snapshot lifetime) (#2431) * Fix deadlock on `removeExpiredSnapshots` (#2461) * Add grafana panels for write throughput per instance (#2524)
This was referenced Aug 4, 2021
JaySon-Huang
pushed a commit
that referenced
this pull request
Aug 5, 2021
* Ignore sequence hole among PageFile meta (#2312) * Fix bug for GC may skip unexpected WriteBatches (#2356) * Add length check while running PageStorage GC (#2394) * PageStorage skip non continuous sequence safely (#2435) * Fix PageStorage GC with high valid rate PageFile (#2436) Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JaySon-Huang jayson.hjs@gmail.com
What problem does this PR solve?
Issue Number: related to #2393
Problem Summary:
In #2356, we assume that
page_filesare not empty. However, unit tests randomly crash after that.BackgroundServiceWhat is changed and how it works?
Add check for the size of
page_fileswhile running PageStorage::gcAnd also we should refine those tests that brutally remove "./tmp", the following fix would be track in #2393
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note